Review Request 129904: fix when sort indicator is shown in list header

[Carlo Vanini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129904/
-----------------------------------------------------------

(Updated Feb. 1, 2017, 11:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kubuntu and Muon Package Management Suite.


Changes
-------

Submitted with commit 63c63848589fc011d2fd39e36351d592d9bfab63 by Carlo Vanini to branch master.


Bugs: 313596
    http://bugs.kde.org/show_bug.cgi?id=313596


Repository: muon


Description
-------

When starting a new search in the package list, and the list is sorted by name, then the results are sorted by relevancy and the indicator is hidden. Clicking on a column header changes the order wrt the selected column.


Diffs
-----

  src/PackageModel/PackageProxyModel.h fea49b7f4ff24202b405c377213677f5fc81cc9c 
  src/PackageModel/PackageProxyModel.cpp 807ad07216e787b9d4c03d8783dd82afde5770f1 
  src/PackageModel/PackageViewHeader.h ada54986cb006d8221938e4a0bd5bbeb458913a0 
  src/PackageModel/PackageViewHeader.cpp e9557ec9ef7792dd55c7e96f423c999e9fd5057c 
  src/PackageModel/PackageWidget.cpp e70e4d3b143769073e706312133375630944f17b 

Diff: https://git.reviewboard.kde.org/r/129904/diff/


Testing
-------

Test 1
------

* Click on 'Status' header
* Search for 'fri' (gives meaningful result to see the order)
* Result is sorted by status and then by name

Test 2
------

* Clear search string, click on 'Package' header
* Search for 'fri'
* Sort indicator is hidden, result is sorted by relevancy
* Click on a header
* Result is order by selected column, indicator is shown
* Continue writing in search string, 'fritz'
* Result is still ordered by column
* Clearing search string and fill it again
* Search result is sorted by relevancy


Thanks,

Carlo Vanini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20170201/3f3e910c/attachment-0001.html>