Review Request 127107: Connect to backend signals to catch cache reload.

Aleix Pol Gonzalez aleixpol at kde.org
Thu Mar 3 00:48:25 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127107/#review93081
-----------------------------------------------------------


Ship it!




- Aleix Pol Gonzalez


On Feb. 19, 2016, 1:31 a.m., Carlo Vanini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127107/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 1:31 a.m.)
> 
> 
> Review request for Kubuntu and Muon Package Management Suite.
> 
> 
> Bugs: 332530
>     http://bugs.kde.org/show_bug.cgi?id=332530
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> When the cache is reloaded libqapt deletes Package objects and creates them anew. This results in dangling pointers in muon models.
> 
> When "Preview Changes" is shown we have two models with lists of packages, and both should be cleared and repopulated.
> 
> The cache reload can be triggered by pinning/unpinning (lock/unlock) a package.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 466ea4bc00773dbd5353a477a10bbb125d021287 
>   src/PackageModel/PackageWidget.h 681b59e6887b04140f899f214d0b8ddc1fc2de3c 
>   src/PackageModel/PackageWidget.cpp 264db785de78295d1e688da77d850993abe7c6d6 
>   src/StatusWidget.cpp ecd17ea402fd93b00ab6fa0773464bbc8a600990 
> 
> Diff: https://git.reviewboard.kde.org/r/127107/diff/
> 
> 
> Testing
> -------
> 
> * mark a package for install/remove
> * click on "Preview Changes"
> * right-click on a package and select "Lock at Current Version"
> 
> Without patch: clicking on "Back" crashes muon
> With patch: no crash, but as a side effect all changes to packages are lost when the cache is reloaded.
> 
> 
> Thanks,
> 
> Carlo Vanini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20160303/3a67959a/attachment.html>


More information about the kubuntu-devel mailing list