Review Request 128337: Remove leading space in description only if present.

Aleix Pol Gonzalez aleixpol at kde.org
Fri Jul 1 23:45:10 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128337/#review96997
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On July 1, 2016, 7:28 p.m., Carlo Vanini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128337/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 7:28 p.m.)
> 
> 
> Review request for Kubuntu and LibQApt.
> 
> 
> Bugs: 316650
>     http://bugs.kde.org/show_bug.cgi?id=316650
> 
> 
> Repository: libqapt
> 
> 
> Description
> -------
> 
> When descriptions are loaded from translation files they start with a
> leading whitespace. But when translations are missing that space is not
> present.  Therefore, remove the first character only if it actully is a
> space.
> 
> BUG: 316650
> 
> 
> Diffs
> -----
> 
>   src/package.cpp 0526f9d3ef8a0d3328a3013756134d3871745671 
> 
> Diff: https://git.reviewboard.kde.org/r/128337/diff/
> 
> 
> Testing
> -------
> 
> Tested with Muon
> 
> Before patching:
> 
> * sudo apt-get -o=Acquire::Languages=none update
> * run Muon and notice the missing character
> 
> After patching:
> 
> * run Muon, the character is there
> * sudo apt-get update # get back translations
> * run Muon, correct description, no leading whitespace
> 
> 
> Thanks,
> 
> Carlo Vanini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20160701/9751c220/attachment.html>


More information about the kubuntu-devel mailing list