Review Request 122017: Fix URI parsing when there's [] in it

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122017/#review73863
-----------------------------------------------------------

Ship it!


looks good except for some format nitpicking.

there's also inconsistency with spacing around operators, couldn't be bothered to highlight them all, so meh


src/sourceentry.cpp
<https://git.reviewboard.kde.org/r/122017/#comment51357>

    stray unreachable qdebug



src/sourceentry.cpp
<https://git.reviewboard.kde.org/r/122017/#comment51360>

    whitepsace between keyword and ( please



src/sourceentry.cpp
<https://git.reviewboard.kde.org/r/122017/#comment51364>

    two lines please



src/sourceentry.cpp
<https://git.reviewboard.kde.org/r/122017/#comment51361>

    whitepsace between keyword and ( please



src/sourceentry.cpp
<https://git.reviewboard.kde.org/r/122017/#comment51362>

    whitepsace between keyword and ( please



src/sourceentry.cpp
<https://git.reviewboard.kde.org/r/122017/#comment51363>

    case should have same indention as switch


- Harald Sitter


On Jan. 12, 2015, 2:59 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122017/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 2:59 p.m.)
> 
> 
> Review request for Kubuntu, Michael Stemle and Harald Sitter.
> 
> 
> Repository: libqapt
> 
> 
> Description
> -------
> 
> Currently the parsing was quite dumb as it started with a .split(' '), so many cases were not being taken into account, most notably this was displayed on uri's like cdrom:
> "cdrom:[Kubuntu 11.10 _Oneiric Ocelot_ - Release amd64 (20111012)]/"
> 
> 
> Diffs
> -----
> 
>   autotests/data/test1.list e2c6aa5 
>   autotests/sourceslisttest.cpp e23f45e 
>   src/sourceentry.cpp c73bfcf 
> 
> Diff: https://git.reviewboard.kde.org/r/122017/diff/
> 
> 
> Testing
> -------
> 
> Added a test testing the offended line, also other tests still pass.
> Also it fixes some tests in Muon.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150112/b76a6d53/attachment.html>