Review Request 122017: Fix URI parsing when there's [] in it
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jan 12 14:59:04 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122017/
-----------------------------------------------------------
Review request for Kubuntu, Michael Stemle and Harald Sitter.
Repository: libqapt
Description
-------
Currently the parsing was quite dumb as it started with a .split(' '), so many cases were not being taken into account, most notably this was displayed on uri's like cdrom:
"cdrom:[Kubuntu 11.10 _Oneiric Ocelot_ - Release amd64 (20111012)]/"
Diffs
-----
autotests/data/test1.list e2c6aa5
autotests/sourceslisttest.cpp e23f45e
src/sourceentry.cpp c73bfcf
Diff: https://git.reviewboard.kde.org/r/122017/diff/
Testing
-------
Added a test testing the offended line, also other tests still pass.
Also it fixes some tests in Muon.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150112/45d2f92f/attachment.html>
More information about the kubuntu-devel
mailing list