Review Request 121920: qml: access reviewsBackend through backend directly rather than the parent

Harald Sitter sitter at kde.org
Thu Jan 8 16:00:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121920/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 4 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kubuntu and Muon Package Management Suite.


Repository: muon


Description
-------

the parent of ReviewDialog is not the button, so going through parent
results in 'undefined'


Diffs
-----

  discover/qml/ApplicationDescription.qml 517649871dd71c6f090c0b05797a3090ab836138 

Diff: https://git.reviewboard.kde.org/r/121920/diff/


Testing
-------

without patch: qml error on undefined

with patch: reviewsbackend is obtained and method is actually called


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150108/214617b8/attachment.html>


More information about the kubuntu-devel mailing list