Review Request 121920: qml: access reviewsBackend through backend directly rather than the parent

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121920/#review73492
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Jan. 8, 2015, 1:31 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121920/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 1:31 p.m.)
> 
> 
> Review request for Kubuntu and Muon Package Management Suite.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> the parent of ReviewDialog is not the button, so going through parent
> results in 'undefined'
> 
> 
> Diffs
> -----
> 
>   discover/qml/ApplicationDescription.qml 517649871dd71c6f090c0b05797a3090ab836138 
> 
> Diff: https://git.reviewboard.kde.org/r/121920/diff/
> 
> 
> Testing
> -------
> 
> without patch: qml error on undefined
> 
> with patch: reviewsbackend is obtained and method is actually called
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150108/b195b049/attachment-0001.html>