Review Request 126341: app notifier is crashing right now. build a test around it

Harald Sitter sitter at kde.org
Mon Dec 14 11:21:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126341/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 11:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for Kubuntu, Muon Package Management Suite and Aleix Pol Gonzalez.


Changes
-------

Submitted with commit 86b6b88dd04d68bc92942c9460335e3efb171fc7 by Harald Sitter to branch Plasma/5.5.


Repository: discover


Description
-------

prevent notifier from crashing when process was not initialized yet


Diffs
-----

  libdiscover/backends/ApplicationBackend/ApplicationNotifier.cpp 7611d046b5761b75f9535415b9b8903fef7ed49b 
  libdiscover/backends/ApplicationBackend/CMakeLists.txt e2bb7fbeecde6983aa48b6bdb79a6c6fd41c83e3 
  libdiscover/backends/ApplicationBackend/tests/CMakeLists.txt 274adf3a1f82ee8cd2f0f1bd6392d005b09195c6 
  libdiscover/backends/ApplicationBackend/tests/NotifierTest.h PRE-CREATION 
  libdiscover/backends/ApplicationBackend/tests/NotifierTest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126341/diff/


Testing
-------

ran test without fix -> exception fail
ran test with fix -> pass


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20151214/5df7390b/attachment.html>


More information about the kubuntu-devel mailing list