Review Request 126341: app notifier is crashing right now. build a test around it

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126341/#review89460
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 14, 2015, 10:36 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126341/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 10:36 a.m.)
> 
> 
> Review request for Kubuntu, Muon Package Management Suite and Aleix Pol Gonzalez.
> 
> 
> Repository: discover
> 
> 
> Description
> -------
> 
> prevent notifier from crashing when process was not initialized yet
> 
> 
> Diffs
> -----
> 
>   libdiscover/backends/ApplicationBackend/ApplicationNotifier.cpp 7611d046b5761b75f9535415b9b8903fef7ed49b 
>   libdiscover/backends/ApplicationBackend/CMakeLists.txt e2bb7fbeecde6983aa48b6bdb79a6c6fd41c83e3 
>   libdiscover/backends/ApplicationBackend/tests/CMakeLists.txt 274adf3a1f82ee8cd2f0f1bd6392d005b09195c6 
>   libdiscover/backends/ApplicationBackend/tests/NotifierTest.h PRE-CREATION 
>   libdiscover/backends/ApplicationBackend/tests/NotifierTest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126341/diff/
> 
> 
> Testing
> -------
> 
> ran test without fix -> exception fail
> ran test with fix -> pass
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20151214/a1ca52f9/attachment.html>