[Bug 1983307] Re: Can't load addons list in a non-English locale (already fixed upstream)

Bug Watch Updater 1983307 at bugs.launchpad.net
Wed Aug 3 02:02:41 UTC 2022 

Launchpad has imported 28 comments from the remote bug at
https://bugs.kde.org/show_bug.cgi?id=451165.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2022-03-05T17:18:41+00:00 Makosol wrote:

Created attachment 147295
error message

SUMMARY
Error message when clicking "Get new icons..." in system settings


STEPS TO REPRODUCE
1.Go to System settings / Appearence / Icons
2. Click the "Get new icons..." button

OBSERVED RESULT
Error message (cf screenshot)

EXPECTED RESULT
Display available Icons from servers

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon 5.24
(available in About System)
KDE Plasma Version: 5.24.2
KDE Frameworks Version: 5.91
Qt Version: 5.15.3

ADDITIONAL INFORMATION

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/0

------------------------------------------------------------------------
On 2022-03-06T22:33:38+00:00 Beluchukwunjike wrote:

Can't confirm this behavior. Everything works great for me.

SOFTWARE/OS VERSIONS
Distro: Manjaro
KDE Plasma Version: 5.24.2
KDE Frameworks Version: 5.91
Qt Version: 5.15.2

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/1

------------------------------------------------------------------------
On 2022-03-07T18:48:29+00:00 Makosol wrote:

Happens also in Fedora 35. Maybe it is linked to french language ?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/2

------------------------------------------------------------------------
On 2022-03-08T00:03:19+00:00 Justin Zobel wrote:

Are you able to try in another language please, that way we can confirm
if that's the issue. I've also not been able to replicate this issue on
Fedora 36 with "American English" Language and en_AU (Australia)
keyboard layout.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/3

------------------------------------------------------------------------
On 2022-03-08T19:22:59+00:00 Makosol wrote:

My system is in french, but in System settings / Language, only American English is present...
I don't know why and I don't know how to make the changes necessary to test the issue.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/4

------------------------------------------------------------------------
On 2022-03-08T20:13:34+00:00 Alexander-lohnau wrote:

(In reply to makosol from comment #2)
> Happens also in Fedora 35. Maybe it is linked to french language ?

Can reproduce when setting the language to french. With my default en_US
it works fine.  In attica one gets a
QNetworkReply::RemoteHostClosedError, @leinir any ideas?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/5

------------------------------------------------------------------------
On 2022-03-09T09:37:50+00:00 Dan Leinir Turthra Jensen wrote:

i mean, apart from the remote host refusing to serve us seeming like it
has to be a service side issue, i'm really not sure... Especially given
how this code just hasn't changed on our side for ages, and it's
suddenly broken... Maybe something with the new caching setup causes it
to fail if there's a language set in the request header? (which we don't
do ourselves, but i expect it gets sent along by qnam, not really sure).
A quick test just trying to manually set the accept-language header to
fr seems to just result in a correctly returned list of categories,
though, so i'm really not sure what's going on here.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/6

------------------------------------------------------------------------
On 2022-03-17T08:29:18+00:00 Dr-4 wrote:

According to KNS, I found out an interesting thing: if the dialog opens
in a category that is not translated (or has Latin characters),
everything is displayed without problems. Those. sections konsole,
yakuake, etc. open, but which contain non-English characters not. Tested
with renaming the translation of /usr/share/knsrcfiles/*

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/7

------------------------------------------------------------------------
On 2022-03-20T12:14:18+00:00 ZaWertun wrote:

This error was caused by this line in KF5 Attica code:
https://invent.kde.org/frameworks/attica/-/blob/dde032d415e26a87f900eb6f0131f5114f0e72f9/src/provider.cpp#L1724

User-Agent header was set to UTF-8 value, "knewstuff-dialog/1.0 (+Вход в систему)" in my case.
It's not valid according to HTTP standard (as I know), so HTTP server breaks connection.

(See also: https://stackoverflow.com/questions/10384741/is-a-unicode-
user-agent-legal-inside-an-http-header)

Commenting this line solves issue for me.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/8

------------------------------------------------------------------------
On 2022-03-20T12:56:56+00:00 ZaWertun wrote:

Maybe it's worth to encode m_additionalAgentInformation with
QUrl::toPercentEncoding(...) before setting it to header.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/9

------------------------------------------------------------------------
On 2022-03-20T19:29:40+00:00 Alexander-lohnau wrote:

I think it is worth rethinking if we even want the user-visible name
inside the user agent. Instead I would propose to use the knsrc file
basename. This is an identifier we use when creating the engine.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/10

------------------------------------------------------------------------
On 2022-03-20T19:34:31+00:00 Bug-janitor wrote:

A possibly relevant merge request was started @
https://invent.kde.org/frameworks/knewstuff/-/merge_requests/173

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/11

------------------------------------------------------------------------
On 2022-03-20T19:35:16+00:00 Alexander-lohnau wrote:

@Yaroslav Sidlovsky Thanks for the valuable investigation!

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/12

------------------------------------------------------------------------
On 2022-03-20T23:46:55+00:00 Justin Zobel wrote:

Thank you so much Yaroslav! Amazing work!

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/13

------------------------------------------------------------------------
On 2022-03-22T01:51:31+00:00 Nate-b wrote:

*** Bug 451087 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/14

------------------------------------------------------------------------
On 2022-03-23T23:00:01+00:00 Nate-b wrote:

Git commit 693a2ea3926400b1482888a2df2c532852b8f971 by Nate Graham, on behalf of Alexander Lohnau.
Committed on 23/03/2022 at 22:58.
Pushed by ngraham into branch 'master'.

Do not set user-visible name as additional agent information

Instead we want the filename, which is more useful as an identifier anyways, because
we would otherwise have to check which user-visible names originate from which knsrc file.

M  +4    -1    src/core/engine.cpp

https://invent.kde.org/frameworks/knewstuff/commit/693a2ea3926400b1482888a2df2c532852b8f971

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/15

------------------------------------------------------------------------
On 2022-03-23T23:41:13+00:00 Justin Zobel wrote:

Created attachment 147691
attachment-12149-0.html

No bugfix release?

On Thu, Mar 24, 2022, 9:32 AM Nate Graham <bugzilla_noreply at kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=451165
>
> Nate Graham <nate at kde.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>    Version Fixed In|                            |5.93
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/16

------------------------------------------------------------------------
On 2022-03-23T23:43:02+00:00 Nate-b wrote:

That would be up to distro packagers or the Frameworks folks. Frameworks
doesn't get automatic bugfix releases, just the normal monthly releases.
So someone would need to request one. Would you be interested in doing
so?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/17

------------------------------------------------------------------------
On 2022-03-23T23:45:36+00:00 Justin Zobel wrote:

Created attachment 147692
attachment-12570-0.html

If this patch cleanly applies to the current frameworks release I guess
there's no need for a separate release. I've already proposed the use of
the patch for Fedora KDE.

On Thu, Mar 24, 2022, 10:13 AM Nate Graham <bugzilla_noreply at kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=451165
>
> --- Comment #17 from Nate Graham <nate at kde.org> ---
> That would be up to distro packagers or the Frameworks folks. Frameworks
> doesn't get automatic bugfix releases, just the normal monthly releases. So
> someone would need to request one. Would you be interested in doing so?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/18

------------------------------------------------------------------------
On 2022-03-24T06:07:20+00:00 Bug-janitor wrote:

A possibly relevant merge request was started @
https://invent.kde.org/frameworks/knewstuff/-/merge_requests/175

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/19

------------------------------------------------------------------------
On 2022-03-24T06:10:18+00:00 Alexander-lohnau wrote:

There is another place where I am not sure how relevant it even is. Once
that is figured out I will reach out to distros and make a backport
request.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/20

------------------------------------------------------------------------
On 2022-03-24T16:41:05+00:00 Alexander-lohnau wrote:

Git commit 3ec15eaac29d6b73b078ffe1665fc68fc2beeeac by Alexander Lohnau.
Committed on 24/03/2022 at 06:02.
Pushed by alex into branch 'master'.

Do not set user-visible name as additional agent information when
copying provider

Instead we want the filename, which is more useful as an identifier anyways, because
we would otherwise have to check which user-visible names originate from which knsrc file.

M  +1    -1    src/core/engine.cpp

https://invent.kde.org/frameworks/knewstuff/commit/3ec15eaac29d6b73b078ffe1665fc68fc2beeeac

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/21

------------------------------------------------------------------------
On 2022-03-27T04:03:59+00:00 Nate-b wrote:

*** Bug 451088 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/22

------------------------------------------------------------------------
On 2022-03-27T04:04:08+00:00 Nate-b wrote:

*** Bug 451611 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/23

------------------------------------------------------------------------
On 2022-03-27T04:04:12+00:00 Nate-b wrote:

*** Bug 451364 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/24

------------------------------------------------------------------------
On 2022-04-01T19:32:16+00:00 Nate-b wrote:

*** Bug 452157 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/25

------------------------------------------------------------------------
On 2022-05-02T18:40:09+00:00 Nate-b wrote:

*** Bug 453066 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/26

------------------------------------------------------------------------
On 2022-05-18T15:41:35+00:00 Nate-b wrote:

*** Bug 453954 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/knewstuff/+bug/1983307/comments/27


** Changed in: knewstuff
       Status: Unknown => Fix Released

** Changed in: knewstuff
   Importance: Unknown => High

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to knewstuff in Ubuntu.
https://bugs.launchpad.net/bugs/1983307

Title:
  Can't load addons list in a non-English locale (already fixed
  upstream)

To manage notifications about this bug go to:
https://bugs.launchpad.net/knewstuff/+bug/1983307/+subscriptions

More information about the kubuntu-bugs mailing list