[SRU][J:linux-bluefield][PATCH v3 4/6] UBUNTU: SAUCE: vfio/pci: Allow MMIO regions to be exported through dma-buf

[William Tu]

The original code based on 5.15 that handles
                } else if (cmd == VFIO_DEVICE_RESET) {
Does not even have this line
vfio_pci_set_power_state(vdev, PCI_D0);

https://github.com/torvalds/linux/commit/f9022e132aab7ca1a40576626c56505ac4b8ef66

William
From: Jason Gunthorpe <jgg at nvidia.com>
Date: Wednesday, September 11, 2024 at 3:44 PM
To: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>
Cc: William Tu <witu at nvidia.com>, kernel-team at lists.ubuntu.com <kernel-team at lists.ubuntu.com>, Vladimir Sokolovsky <vlad at nvidia.com>, Bodong Wang <bodong at nvidia.com>, Sergey Gorenko <sergeygo at nvidia.com>, Ziv Waksman <zwaksman at nvidia.com>
Subject: Re: [SRU][J:linux-bluefield][PATCH v3 4/6] UBUNTU: SAUCE: vfio/pci: Allow MMIO regions to be exported through dma-buf
On Wed, Sep 11, 2024 at 10:11:16AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > @@ -2138,11 +2152,16 @@ static int vfio_pci_dev_set_hot_reset(struct vfio_device_set *dev_set,
> >          * cause the PCI config space reset without restoring the original
> >          * state (saved locally in 'vdev->pm_save').
> >          */
> > -       list_for_each_entry(cur, &dev_set->device_list, vdev.dev_set_list)
> > -               vfio_pci_set_power_state(cur, PCI_D0);
>
> The above power management code is removed (similarly like in the
> patch #3/6). Is this correct/intended?
>
> (It doesn't look correct for me as even if it may be not required for
> Bluefield VFIO PCI devices it will be missing now for all other
> devices, including ones that need it. OTOH if it is correct/intended
> the comment above should be probably updated/removed.)

At least my original patch kept the vfio_pci_set_power_state()

Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240912/1b00dcb2/attachment.html>