<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:10.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#467886;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="#467886" vlink="#96607D" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">The original code based on 5.15 that handles
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> } else if (cmd == VFIO_DEVICE_RESET) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Does not even have this line<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:.5in"><span style="font-size:11.0pt">vfio_pci_set_power_state(vdev, PCI_D0);<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:.5in"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><a href="https://github.com/torvalds/linux/commit/f9022e132aab7ca1a40576626c56505ac4b8ef66">https://github.com/torvalds/linux/commit/f9022e132aab7ca1a40576626c56505ac4b8ef66</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">William<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p></o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Jason Gunthorpe <jgg@nvidia.com><br>
<b>Date: </b>Wednesday, September 11, 2024 at 3:44 PM<br>
<b>To: </b>Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com><br>
<b>Cc: </b>William Tu <witu@nvidia.com>, kernel-team@lists.ubuntu.com <kernel-team@lists.ubuntu.com>, Vladimir Sokolovsky <vlad@nvidia.com>, Bodong Wang <bodong@nvidia.com>, Sergey Gorenko <sergeygo@nvidia.com>, Ziv Waksman <zwaksman@nvidia.com><br>
<b>Subject: </b>Re: [SRU][J:linux-bluefield][PATCH v3 4/6] UBUNTU: SAUCE: vfio/pci: Allow MMIO regions to be exported through dma-buf<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">On Wed, Sep 11, 2024 at 10:11:16AM +0200, Bartlomiej Zolnierkiewicz wrote:<br>
> > @@ -2138,11 +2152,16 @@ static int vfio_pci_dev_set_hot_reset(struct vfio_device_set *dev_set,<br>
> > * cause the PCI config space reset without restoring the original<br>
> > * state (saved locally in 'vdev->pm_save').<br>
> > */<br>
> > - list_for_each_entry(cur, &dev_set->device_list, vdev.dev_set_list)<br>
> > - vfio_pci_set_power_state(cur, PCI_D0);<br>
> <br>
> The above power management code is removed (similarly like in the<br>
> patch #3/6). Is this correct/intended?<br>
> <br>
> (It doesn't look correct for me as even if it may be not required for<br>
> Bluefield VFIO PCI devices it will be missing now for all other<br>
> devices, including ones that need it. OTOH if it is correct/intended<br>
> the comment above should be probably updated/removed.)<br>
<br>
At least my original patch kept the vfio_pci_set_power_state()<br>
<br>
Jason <o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>