NACK/Cmnt: [SRU][N][PATCH v4 0/1] rtw89: Support hardware rfkill

[Mehmet Basaran]

I think changes mostly from the upstream which are OK.

But this patch also includes some other changes:

1. It seems patch adds the following declaration in core.h though it
   already exists (because of this patch does not apply):

+void rtw89_check_quirks(struct rtw89_dev *rtwdev, const struct dmi_system_id *quirks);

2. There are additional changes which are not in the original commit
   (0b38e6277aed8a59ccb64fcc1172d962c1f11b4c) in
   drivers/net/wireless/realtek/rtw89/rtw8922a.c. It seems you included
   extra code from the following commits:
    - d16f34b084d9734644932ca17812baec56fb0041
    - d2ff221579e5b281376e84ea9669115723b753b9

   But these added registers are not used anywhere else? I am thinking
   we either need to remove those definitions or work on this patch more
   (possibly backporting listed commits or possibly including what you
   need as a separate SAUCE patch).


I am thinking, this definitely needs a rework because of (1) and we can
elaborate on (2) in case I am missing the point.

Nacked-by: Mehmet Basaran <mehmet.basaran at canonical.com>

-------------- next part --------------
En-Wei Wu <en-wei.wu at canonical.com> writes:

> BugLink: https://bugs.launchpad.net/bugs/2077384
>
> SRU Justification:
>
> [Impact]
> With RTL8851BE and "Control WLAN radio" (in Dell BIOS setting) on, wifi function 
> is not be disabled when we plug in the Ethernet cable. The issue is because the 
> rtw89 driver doesn't have the hardware rfkill mechanism.
>
> [Fix]
> Backport the Realtek patch in linux-next:
>
> https://lore.kernel.org/linux-wireless/20240724052626.12774-1-pkshih@realtek.com/T/#m1361ad1d6125d64976677fea4ba2e3aff219d1ad
>
> [Test Plan]
> 1. Enable Control WLAN radio in BIOS setting
> 2. Boot into OS
> 2. Plug in Ethernet cable.
> 3. Check if the WiFi function being HW blocked
>
> [Where problems could occur]
> May disrupt the software rfkill.
>
> Kuan-Chung Chen (1):
>   wifi: rtw89: add support for hardware rfkill
>
>  drivers/net/wireless/realtek/rtw89/core.c     | 68 +++++++++++++++++++
>  drivers/net/wireless/realtek/rtw89/core.h     | 10 +++
>  drivers/net/wireless/realtek/rtw89/mac80211.c | 17 +++++
>  drivers/net/wireless/realtek/rtw89/reg.h      | 24 +++++++
>  drivers/net/wireless/realtek/rtw89/rtw8851b.c | 11 +++
>  drivers/net/wireless/realtek/rtw89/rtw8852a.c | 11 +++
>  drivers/net/wireless/realtek/rtw89/rtw8852b.c | 11 +++
>  drivers/net/wireless/realtek/rtw89/rtw8852c.c | 11 +++
>  drivers/net/wireless/realtek/rtw89/rtw8922a.c | 56 +++++++++++++++
>  9 files changed, 219 insertions(+)
>
> -- 
> 2.43.0
>
>
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 873 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20241004/3b934492/attachment.sig>