[J] [PATCH 1/2] iwlwifi: mvm: Don't fail if PPAG isn't supported

Kai-Heng Feng kai.heng.feng at canonical.com
Wed Oct 11 06:09:28 UTC 2023


From: Miri Korenblit <miriam.rachel.korenblit at intel.com>

BugLink: https://bugs.launchpad.net/bugs/2037513

When we're copying the PPAG table into the cmd structure we're failing
if the table doesn't exist in ACPI or is invalid, or if the FW doesn't
support PPAG setting etc.

This is wrong because those are valid scenarios.  Fix this by not
failing in those cases.

Fixes: e8e10a37c51c ("iwlwifi: acpi: move ppag code from mvm to fw/acpi")
Tested-by: Oliver Hartkopp <socketcan at hartkopp.net>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit at intel.com>
Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
Acked-by: Kalle Valo <kvalo at kernel.org>
Link: https://lore.kernel.org/r/iwlwifi.20220322173828.fa47f369b717.I6a9c65149c2c3c11337f3a802dff22f514a3a436@changeid
Signed-off-by: Jakub Kicinski <kuba at kernel.org>
(backported from commit b20bdd9cc9740ac1f2138adab25ddd51245c67be)
[khfeng: Move the changeset to before the code gets refactored]
Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 6d439ae7b50b..175e492aa6e9 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1029,7 +1029,7 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm)
 		IWL_ERR(mvm, "failed to send PER_PLATFORM_ANT_GAIN_CMD (%d)\n",
 			ret);
 
-	return ret;
+	return 0;
 }
 
 static const struct dmi_system_id dmi_ppag_approved_list[] = {
-- 
2.34.1




More information about the kernel-team mailing list