Cmt: [kernel-snaps-uc22:pi][PATCH] snapcraft.yaml: Fill in missing metadata

[Dimitri John Ledkov]

Hi,

On Fri, 6 Oct 2023 at 09:55, Juerg Haefliger
<juerg.haefliger at canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2038479
>
> Fill in missing metadata so that 'snap info <name>' returns useful
> information for people who want to report problems.
>
> While at it, tidy up the summary and description and make them
> consistent across all kernel snaps.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
> ---
>  snapcraft.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 1fbf6eb6c70b..5151c669941d 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -1,7 +1,11 @@
>  name: pi-kernel
>  version: 5.15.0-1038.41
> -summary: The Canonical Raspberry Pi kernel
> -description: The Canonical Raspberry Pi kernel
> +summary: Raspberry Pi Ubuntu kernel
> +description: The Raspberry Pi Ubuntu kernel package as a snap
> +source-code: https://git.launchpad.net/~canonical-kernel-snaps/+git/kernel-snaps-uc22
> +issues: https://bugs.launchpad.net/canonical-kernel-snaps/+filebug?field.tags=pi-kernel
> +contact: https://bugs.launchpad.net/canonical-kernel-snaps/+filebug?field.tags=pi-kernel
> +license: GPLv2

I like all updates. I have question about 'source-code' i believe this
is automatically populated during the build into manifest.txt
indirectly

```
image-info:
  build-request-id: lp-82294272
  build-request-timestamp: '2023-09-11T15:15:10Z'
  build_url: https://launchpad.net/~canonical-kernel-snaps/+snap/pi-kernel--uc22/+build/2226329
```

VCS revision: ca401316295bbceabdca66386ef9a9e6ec346cd9
But yeah, I don't see source code url.

It seems a bit self-referencing to specify url or the repository that
contains the snapcraft.yaml. Is this even part of the snapcraft.yaml
reference syntax? cause i would have hoped that would be
auto-populated from where the build has happened.

>  type: kernel
>  confinement: strict
>  build-base: core22
> --
> 2.39.2
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



-- 
okurrr,

Dimitri