ACK/Cmnt: [kernel-snaps-uc22:pi][PATCH] snapcraft.yaml: Fill in missing metadata

Tim Gardner tim.gardner at canonical.com
Fri Oct 6 16:53:23 UTC 2023


On 10/6/23 2:54 AM, Juerg Haefliger wrote:
> BugLink: https://bugs.launchpad.net/bugs/2038479
> 
> Fill in missing metadata so that 'snap info <name>' returns useful
> information for people who want to report problems.
> 
> While at it, tidy up the summary and description and make them
> consistent across all kernel snaps.
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
> ---
>   snapcraft.yaml | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 1fbf6eb6c70b..5151c669941d 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -1,7 +1,11 @@
>   name: pi-kernel
>   version: 5.15.0-1038.41
> -summary: The Canonical Raspberry Pi kernel
> -description: The Canonical Raspberry Pi kernel
> +summary: Raspberry Pi Ubuntu kernel
> +description: The Raspberry Pi Ubuntu kernel package as a snap
> +source-code: https://git.launchpad.net/~canonical-kernel-snaps/+git/kernel-snaps-uc22
> +issues: https://bugs.launchpad.net/canonical-kernel-snaps/+filebug?field.tags=pi-kernel
> +contact: https://bugs.launchpad.net/canonical-kernel-snaps/+filebug?field.tags=pi-kernel
> +license: GPLv2
>   type: kernel
>   confinement: strict
>   build-base: core22
Acked-by: Tim Gardner <tim.gardner at canonical.com>

LGTM assuming you meant for issues and contacts to have the same URL.
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list