NACK: [PATCH] [kernel-snaps-uc22/main] Add missing Atheros firmware files

[Juerg Haefliger]

On Fri, 6 Oct 2023 09:53:46 +0200
Sergio Costas Rodriguez <sergio.costas at canonical.com> wrote:

> Hi:
> 
> El 6/10/23 a las 8:22, Juerg Haefliger escribió:
> >> +# Copy extra AthrBT files, because they are needed for some devices
> >> +# like the original Asus Zenbook; but do it only if the module ath3k.ko
> >> +# is compiled. The file ath3k-1.fw is already being copied, so
> >> +# it doesn't need to be managed here.
> >> +if [ -n `find "${DESTDIR}"/modules -name 'ath3k.ko*'` ] ; then  
> > As mentioned already , ticks (`..`) should be avoided:.
> > SC2006 (style): Use $(...) notation instead of legacy backticks `...`.  
> Ops... sorry, I just copied your line and presumed that it was already 
> fixed. I'll change it.
> >> +	mkdir -p "${DESTDIR}"/firmware.new/ar3k
> >> +	cp -a "${DESTDIR}"/firmware/ar3k/AthrBT_0x*.dfu "${DESTDIR}"/firmware.new/ar3k/
> >> +	# the "ramps_" files are also refered in the source code of the driver, so
> >> +	# we must add them too.
> >> +	cp -a "${DESTDIR}"/firmware/ar3k/ramps_0x*.dfu "${DESTDIR}"/firmware.new/ar3k/
> >> +fi  
> > You haven't addressed/answered my question from my previous review:
> >
> > What about ath3k-1.fw?
> >
> > ...Juerg  
> 
> I added a comment in the patch that explains that ath3k-1.fw is already 
> being copied because it is in the firmware root folder. It's before the 
> function. If you prefer, I can move it into the IF statement...

Ah sorry my bad, missed that. It's fine as it is.


> I'll prepare a new patch with the other change.

Thanks!

..Juerg

 
> >  
> >>   # Move kernel firmware files to the new firmware directory
> >>   for d in "${DESTDIR}"/modules/* ; do
> >>   	if [ -d "${DESTDIR}"/firmware/"${d##*/}" ] ; then  

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231006/1424e33d/attachment.sig>