NACK: [PATCH] [kernel-snaps-uc22/main] Add missing Atheros firmware files

[Sergio Costas Rodriguez]

Hi:

El 6/10/23 a las 8:22, Juerg Haefliger escribió:
>> +# Copy extra AthrBT files, because they are needed for some devices
>> +# like the original Asus Zenbook; but do it only if the module ath3k.ko
>> +# is compiled. The file ath3k-1.fw is already being copied, so
>> +# it doesn't need to be managed here.
>> +if [ -n `find "${DESTDIR}"/modules -name 'ath3k.ko*'` ] ; then
> As mentioned already , ticks (`..`) should be avoided:.
> SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Ops... sorry, I just copied your line and presumed that it was already 
fixed. I'll change it.
>> +	mkdir -p "${DESTDIR}"/firmware.new/ar3k
>> +	cp -a "${DESTDIR}"/firmware/ar3k/AthrBT_0x*.dfu "${DESTDIR}"/firmware.new/ar3k/
>> +	# the "ramps_" files are also refered in the source code of the driver, so
>> +	# we must add them too.
>> +	cp -a "${DESTDIR}"/firmware/ar3k/ramps_0x*.dfu "${DESTDIR}"/firmware.new/ar3k/
>> +fi
> You haven't addressed/answered my question from my previous review:
>
> What about ath3k-1.fw?
>
> ...Juerg

I added a comment in the patch that explains that ath3k-1.fw is already 
being copied because it is in the firmware root folder. It's before the 
function. If you prefer, I can move it into the IF statement...

I'll prepare a new patch with the other change.

>
>>   # Move kernel firmware files to the new firmware directory
>>   for d in "${DESTDIR}"/modules/* ; do
>>   	if [ -d "${DESTDIR}"/firmware/"${d##*/}" ] ; then
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231006/ca413d9c/attachment.html>