NACK/Cmnt: [SRU][F:linux-bluefield][PATCH v1 0/5] Support hardware miss to tc action

[William Tu]

Hi Stefan,

Sorry about that, resent the series here
https://lists.ubuntu.com/archives/kernel-team/2023-March/138028.html

William

From: kernel-team <kernel-team-bounces at lists.ubuntu.com> on behalf of Stefan Bader <stefan.bader at canonical.com>
Date: Friday, March 24, 2023 at 1:48 AM
To: kernel-team at lists.ubuntu.com <kernel-team at lists.ubuntu.com>
Subject: NACK/Cmnt: [SRU][F:linux-bluefield][PATCH v1 0/5] Support hardware miss to tc action
External email: Use caution opening links or attachments


On 23.03.23 20:15, William Tu wrote:
> Currently tc miss interface only supports resuming from a specific tc chain.
> If a packet modification is done before a missable action such as CT and
> there is a miss in CT after it, this may cause a miss match when resuming
> re-executing the same chain in software, and wrong packet count.
> This use case for example is a stateless (static) nat.
>
> * brief explanation of fixes
>
> Add support for missing to a specific action instance, and support
> of per action hardware stats to update what was actually done in hardware.
>
> BugLink: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fbugs%2F2012571&data=05%7C01%7Cwitu%40nvidia.com%7C5117e1b13ee54f5237b508db2c448a80%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638152445141566541%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZunvfLuhMAEnnq8b4gWrOPUuoPhmFsT%2FHHOME8DcYNA%3D&reserved=0
>
> Eric Dumazet (1):
>    net/sched: flower: fix fl_change() error recovery path
>
> Paul Blakey (4):
>    net/sched: Provide act to offload action
>    net/sched: cls_api: Support hardware miss to tc action
>    net/sched: flower: Move filter handle initialization earlier
>    net/sched: flower: Support hardware miss to tc action
>
>   include/linux/skbuff.h     |   6 +-
>   include/net/flow_offload.h |   2 +
>   include/net/pkt_cls.h      |  30 +++--
>   include/net/sch_generic.h  |   2 +
>   net/openvswitch/flow.c     |   3 +-
>   net/sched/cls_api.c        | 217 +++++++++++++++++++++++++++++++++++--
>   net/sched/cls_flower.c     |  79 +++++++++-----
>   7 files changed, 288 insertions(+), 51 deletions(-)
>

Rejected for the following reasons:

- incomplete, has follow-ups.

-Stefan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230324/863ca68c/attachment-0001.html>