NACK/Cmnt: [SRU][F:linux-bluefield][PATCH v1 0/5] Support hardware miss to tc action

[Stefan Bader]

On 23.03.23 20:15, William Tu wrote:
> Currently tc miss interface only supports resuming from a specific tc chain.
> If a packet modification is done before a missable action such as CT and
> there is a miss in CT after it, this may cause a miss match when resuming
> re-executing the same chain in software, and wrong packet count.
> This use case for example is a stateless (static) nat.
> 
> * brief explanation of fixes
> 
> Add support for missing to a specific action instance, and support
> of per action hardware stats to update what was actually done in hardware.
> 
> BugLink: https://bugs.launchpad.net/bugs/2012571
> 
> Eric Dumazet (1):
>    net/sched: flower: fix fl_change() error recovery path
> 
> Paul Blakey (4):
>    net/sched: Provide act to offload action
>    net/sched: cls_api: Support hardware miss to tc action
>    net/sched: flower: Move filter handle initialization earlier
>    net/sched: flower: Support hardware miss to tc action
> 
>   include/linux/skbuff.h     |   6 +-
>   include/net/flow_offload.h |   2 +
>   include/net/pkt_cls.h      |  30 +++--
>   include/net/sch_generic.h  |   2 +
>   net/openvswitch/flow.c     |   3 +-
>   net/sched/cls_api.c        | 217 +++++++++++++++++++++++++++++++++++--
>   net/sched/cls_flower.c     |  79 +++++++++-----
>   7 files changed, 288 insertions(+), 51 deletions(-)
> 

Rejected for the following reasons:

- incomplete, has follow-ups.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230324/75b19e3f/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230324/75b19e3f/attachment-0001.sig>