[PATCH 4/6] [SRU][K] ALSA: pdaudiocf: Drop superfluous GFP setup
Koba Ko
koba.ko at canonical.com
Fri Mar 24 09:44:00 UTC 2023
From: Takashi Iwai <tiwai at suse.de>
BugLink: https://bugs.launchpad.net/bugs/2009136
The extra setup with GFP_DMA32 is superfluous for this driver. The
whole operation is a simple copy loop, and there is no memory address
restriction at all. Drop the useless GFP setup.
Link: https://lore.kernel.org/r/20220823115740.14123-3-tiwai@suse.de
Change-Id: I9720231b6d430278c984bb116d7a7d4491c5a9eb
Signed-off-by: Takashi Iwai <tiwai at suse.de>
(cherry picked from commit 63bfc84672bbdfc19e54ce181d094fc1aab09e8c)
Signed-off-by: Koba Ko <koba.ko at canonical.com>
---
sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c b/sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c
index dfc4295b69c41..aaa82ec36540d 100644
--- a/sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c
+++ b/sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c
@@ -257,8 +257,7 @@ int snd_pdacf_pcm_new(struct snd_pdacf *chip)
return err;
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &pdacf_pcm_capture_ops);
- snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC,
- snd_dma_continuous_data(GFP_KERNEL | GFP_DMA32),
+ snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC, NULL,
0, 0);
pcm->private_data = chip;
--
2.25.1
More information about the kernel-team
mailing list