[PATCH 3/6] [SRU][K] ALSA: vx: Drop superfluous GFP setup
Koba Ko
koba.ko at canonical.com
Fri Mar 24 09:43:59 UTC 2023
From: Takashi Iwai <tiwai at suse.de>
BugLink: https://bugs.launchpad.net/bugs/2009136
The extra setup with GFP_DMA32 is superfluous for this driver. The
whole operation is a simple copy loop, and there is no memory address
restriction at all. Drop the useless GFP setup.
Link: https://lore.kernel.org/r/20220823115740.14123-2-tiwai@suse.de
Change-Id: Id77781f2093d7d5ddb3478558ea8516e553646ac
Signed-off-by: Takashi Iwai <tiwai at suse.de>
(cherry picked from commit a5ed0c547d50d30a60d67b0911b4ec2c85c54310)
Signed-off-by: Koba Ko <koba.ko at canonical.com>
---
sound/drivers/vx/vx_pcm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/drivers/vx/vx_pcm.c b/sound/drivers/vx/vx_pcm.c
index 3924f5283745e..ceaeb257003bc 100644
--- a/sound/drivers/vx/vx_pcm.c
+++ b/sound/drivers/vx/vx_pcm.c
@@ -1215,8 +1215,7 @@ int snd_vx_pcm_new(struct vx_core *chip)
if (ins)
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &vx_pcm_capture_ops);
snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC,
- snd_dma_continuous_data(GFP_KERNEL | GFP_DMA32),
- 0, 0);
+ NULL, 0, 0);
pcm->private_data = chip;
pcm->private_free = snd_vx_pcm_free;
--
2.25.1
More information about the kernel-team
mailing list