NAK: [SRU][F:linux-bluefield][PATCH v1 0/2] Add HW offloaded CT stats

[William Tu]

Hi Tim,
Thanks for your feedback!
I will address these and resubmit.
William

From: Tim Gardner <tim.gardner at canonical.com>
Date: Thursday, February 23, 2023 at 10:45 AM
To: William Tu <witu at nvidia.com>, kernel-team at lists.ubuntu.com <kernel-team at lists.ubuntu.com>
Cc: Bodong Wang <bodong at nvidia.com>, Vladimir Sokolovsky <vlad at nvidia.com>, dann.frazier at canonical.com <dann.frazier at canonical.com>
Subject: NAK: [SRU][F:linux-bluefield][PATCH v1 0/2] Add HW offloaded CT stats
External email: Use caution opening links or attachments


On 2/23/23 11:11 AM, William Tu wrote:
> BugLink: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fbugs%2F2008136&data=05%7C01%7Cwitu%40nvidia.com%7C0518085841cc47d7a9d408db15ce283c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638127747411654120%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=t3Z55ZLEDPeaE4bihWCJa5WjnpX5KeS%2FPSV4K%2F0uRrY%3D&reserved=0
>
> When CT HW offload is enabled, the CT stats does not show the stats of
> the offloaded flow. Ex: using 'cat /proc/net/nf_conntrack', or
> 'conntrack -L' shows only the software CT stats, not the offloaded CT
> flow stats.
>
> The series cherry-pick two patches below
> ef803b3cf96a ("netfilter: flowtable: add counter support in HW offload")
> 9312eabab4a6 ("netfilter: conntrack: add nf_ct_acct_add()")
> I need to change a little due to cherry-pick conflict with
> 24384e28586c ("netfilter: flowtable: Set offload timeouts according to
> proto values")
>
> wenxu (2):
>    netfilter: conntrack: add nf_ct_acct_add()
>    netfilter: flowtable: add counter support in HW offload
>
>   include/net/netfilter/nf_conntrack_acct.h | 11 ++++++++++-
>   net/netfilter/nf_conntrack_core.c         |  7 ++++---
>   net/netfilter/nf_flow_table_offload.c     | 12 ++++++++++++
>   3 files changed, 26 insertions(+), 4 deletions(-)
>

Patch 2 has a comment below your Signed-off-by that implies the patch is
a backport instead of a cherry pick. Furthermore, the comment 'fix
flow_offload_get_timeout' makes no sense to me.

--
-----------
Tim Gardner
Canonical, Inc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230223/37aee92d/attachment.html>