<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Tim,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thanks for your feedback!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I will address these and resubmit.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">William<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Tim Gardner <tim.gardner@canonical.com><br>
<b>Date: </b>Thursday, February 23, 2023 at 10:45 AM<br>
<b>To: </b>William Tu <witu@nvidia.com>, kernel-team@lists.ubuntu.com <kernel-team@lists.ubuntu.com><br>
<b>Cc: </b>Bodong Wang <bodong@nvidia.com>, Vladimir Sokolovsky <vlad@nvidia.com>, dann.frazier@canonical.com <dann.frazier@canonical.com><br>
<b>Subject: </b>NAK: [SRU][F:linux-bluefield][PATCH v1 0/2] Add HW offloaded CT stats<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt">External email: Use caution opening links or attachments<br>
<br>
<br>
On 2/23/23 11:11 AM, William Tu wrote:<br>
> BugLink: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fbugs%2F2008136&data=05%7C01%7Cwitu%40nvidia.com%7C0518085841cc47d7a9d408db15ce283c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638127747411654120%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=t3Z55ZLEDPeaE4bihWCJa5WjnpX5KeS%2FPSV4K%2F0uRrY%3D&reserved=0">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fbugs%2F2008136&data=05%7C01%7Cwitu%40nvidia.com%7C0518085841cc47d7a9d408db15ce283c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638127747411654120%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=t3Z55ZLEDPeaE4bihWCJa5WjnpX5KeS%2FPSV4K%2F0uRrY%3D&reserved=0</a><br>
><br>
> When CT HW offload is enabled, the CT stats does not show the stats of<br>
> the offloaded flow. Ex: using 'cat /proc/net/nf_conntrack', or<br>
> 'conntrack -L' shows only the software CT stats, not the offloaded CT<br>
> flow stats.<br>
><br>
> The series cherry-pick two patches below<br>
> ef803b3cf96a ("netfilter: flowtable: add counter support in HW offload")<br>
> 9312eabab4a6 ("netfilter: conntrack: add nf_ct_acct_add()")<br>
> I need to change a little due to cherry-pick conflict with<br>
> 24384e28586c ("netfilter: flowtable: Set offload timeouts according to<br>
> proto values")<br>
><br>
> wenxu (2):<br>
> netfilter: conntrack: add nf_ct_acct_add()<br>
> netfilter: flowtable: add counter support in HW offload<br>
><br>
> include/net/netfilter/nf_conntrack_acct.h | 11 ++++++++++-<br>
> net/netfilter/nf_conntrack_core.c | 7 ++++---<br>
> net/netfilter/nf_flow_table_offload.c | 12 ++++++++++++<br>
> 3 files changed, 26 insertions(+), 4 deletions(-)<br>
><br>
<br>
Patch 2 has a comment below your Signed-off-by that implies the patch is<br>
a backport instead of a cherry pick. Furthermore, the comment 'fix<br>
flow_offload_get_timeout' makes no sense to me.<br>
<br>
--<br>
-----------<br>
Tim Gardner<br>
Canonical, Inc<o:p></o:p></span></p>
</div>
</div>
</body>
</html>