[SRU][F/K][PATCH 0/1] Enable selftests/net/fcnal-test.sh to run

[Po-Hsu Lin]

On Tue, Feb 7, 2023 at 4:33 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 06.02.23 23:57, Luke Nowakowski-Krijger wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2006391
> >
> > [Impact]
> >
> > fcnal-test.sh in selftests/net gets skipped with 'nettest' command not found
> > because its looking for the nettest binary in the path and not in the
> > current directory where the binary is built and run from.
> >
> > There are also other tests in net that are skipped due to this binary
> > not being found.
> >
> > [Fix]
> >
> > Add the current directory to the path and check again.
> > This patch exists in Jammy through a stable update but hasn't made it to
> > the other upstream-stable trees yet, but might as well get the patch in
> > our other trees to enable this test to run.
> >
> > [Backport]
> >
> > For focal patch skip the pmtu.sh file as nettest is not run there and is
> > not checked. Also minor context adjustments on return variable.
> >
> > [Potential regression]
> >
> > None. Just enabling the tests to run.
>
> Not quite. From what I can see in Jammy, there seem to be 2 sub-tests which
> fail. That would look like a regression. Also the whole suite seems to be
> running rather long. Francis said he would look into doing a run to gather how
> long exactly. Without adjusting the timeout it will show up as a problem for
> sure. Maybe it would be better to wait until we have resolved those problems
> before adding it to more series.
>
I guess you mean enabling this will allow us to capture new failures
from fcnal-test.sh test on F/K. (BTW there is another test result
processing issue for this test
https://bugs.launchpad.net/bugs/2006692, which is affecting F/J. We
won't see test marked as failed until it got fixed.)

For the timeout adjustment, Francis has finished the investigation:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/2006499
And the change has landed in our testing tools. Tests on Jammy can
finish properly now. I think we can proceed the review process of this
patch.

Sam


> -Stefan
> >
> > [Tests]
> >
> > Verified tests are now not skipped and run.
> >
> > Daniel Díaz (1):
> >    selftests/net: Find nettest in current directory
> >
> >   tools/testing/selftests/net/fcnal-test.sh | 11 +++++++----
> >   tools/testing/selftests/net/pmtu.sh       | 10 ++++++----
> >   2 files changed, 13 insertions(+), 8 deletions(-)
> >
>