[SRU][F/K][PATCH 0/1] Enable selftests/net/fcnal-test.sh to run

[Stefan Bader]

On 06.02.23 23:57, Luke Nowakowski-Krijger wrote:
> BugLink: https://bugs.launchpad.net/bugs/2006391
> 
> [Impact]
> 
> fcnal-test.sh in selftests/net gets skipped with 'nettest' command not found
> because its looking for the nettest binary in the path and not in the
> current directory where the binary is built and run from.
> 
> There are also other tests in net that are skipped due to this binary
> not being found.
> 
> [Fix]
> 
> Add the current directory to the path and check again.
> This patch exists in Jammy through a stable update but hasn't made it to
> the other upstream-stable trees yet, but might as well get the patch in
> our other trees to enable this test to run.
> 
> [Backport]
> 
> For focal patch skip the pmtu.sh file as nettest is not run there and is
> not checked. Also minor context adjustments on return variable.
> 
> [Potential regression]
> 
> None. Just enabling the tests to run.

Not quite. From what I can see in Jammy, there seem to be 2 sub-tests which 
fail. That would look like a regression. Also the whole suite seems to be 
running rather long. Francis said he would look into doing a run to gather how 
long exactly. Without adjusting the timeout it will show up as a problem for 
sure. Maybe it would be better to wait until we have resolved those problems 
before adding it to more series.

-Stefan
> 
> [Tests]
> 
> Verified tests are now not skipped and run.
> 
> Daniel Díaz (1):
>    selftests/net: Find nettest in current directory
> 
>   tools/testing/selftests/net/fcnal-test.sh | 11 +++++++----
>   tools/testing/selftests/net/pmtu.sh       | 10 ++++++----
>   2 files changed, 13 insertions(+), 8 deletions(-)
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230207/43d5af89/attachment.sig>