[Unstable/Lunar][PATCH 5/5] UBUNTU: [Packaging] annotations: Write out annotations with notes first

[Juerg Haefliger]

On Wed, 8 Feb 2023 07:57:40 +0100
Andrea Righi <andrea.righi at canonical.com> wrote:

> On Tue, Feb 07, 2023 at 08:36:07AM +0100, Juerg Haefliger wrote:
> > When writing the annotations file, separate them  into two groups: With
> > and without a note. Write the group with notes first and separate the
> > other group with a visual marker.
> > 
> > The idea is that all configs that are set/modified manually should have
> > an annotation note and putting them at the top of the annotations file
> > should make it easier to figure out what the config of this kernel is
> > about.  
> 
> I'm wondering if we should move the configs-with-note group at the end of
> the file to make sure that we always prioritize configs-with-note over
> configs-without-note, so that we're not tempted to add stuff at the top
> that can be potentially overridden by the same config rule defined later
> in the same file (typically this shouldn't happen if we search for the
> config that we want to change, but I think the config-with-note at the
> end is less bug prone).

Policies with notes are manually added and important so should be a the top
IMO. Otherwise they get (visually) lost at the end after 1000s of mechanically
added policies. And policies with notes should take precedence over ones
without notes, no? So that way we can't loose them.

...Juerg

 
> If the reason is a better readability we can still provide an
> annotations command to query/show only configs with a note.
> 
> What do you think?
> 
> Thanks,
> -Andrea

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230208/99858d07/attachment-0001.sig>