[Unstable/Lunar][PATCH 5/5] UBUNTU: [Packaging] annotations: Write out annotations with notes first

Andrea Righi andrea.righi at canonical.com
Wed Feb 8 06:57:40 UTC 2023


On Tue, Feb 07, 2023 at 08:36:07AM +0100, Juerg Haefliger wrote:
> When writing the annotations file, separate them  into two groups: With
> and without a note. Write the group with notes first and separate the
> other group with a visual marker.
> 
> The idea is that all configs that are set/modified manually should have
> an annotation note and putting them at the top of the annotations file
> should make it easier to figure out what the config of this kernel is
> about.

I'm wondering if we should move the configs-with-note group at the end of
the file to make sure that we always prioritize configs-with-note over
configs-without-note, so that we're not tempted to add stuff at the top
that can be potentially overridden by the same config rule defined later
in the same file (typically this shouldn't happen if we search for the
config that we want to change, but I think the config-with-note at the
end is less bug prone).

If the reason is a better readability we can still provide an
annotations command to query/show only configs with a note.

What do you think?

Thanks,
-Andrea



More information about the kernel-team mailing list