APPLIED: [SRU][J:linux-bluefield][PATCH v1 0/1] net/mlxbf_gige: Fix an IS_ERR() vs NULL bug in mlxbf_gige_mdio_probe

Bartlomiej Zolnierkiewicz bartlomiej.zolnierkiewicz at canonical.com
Tue Oct 18 10:26:58 UTC 2022


Applied to jammy:linux-bluefield. Thanks.

--
Best regards,
Bartlomiej

On Fri, Sep 30, 2022 at 5:25 PM David Thompson <davthompson at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1991403
>
> SRU Justification:
>
> [Impact]
>
> The following upstream commit was recently added to Jammy:
>   3a1a274e933f mlxbf_gige: compute MDIO period based on i1clk
>
> This patch added driver logic that includes a "devm_ioremap"
> call, but the error handling logic pertaining to this call
> is incorrect.
>
> [Fix]
>
> The "devm_ioremap" function returns NULL on error, it doesn't
> return error pointers. The error handling logic has been
> fixed accordingly.
>
> [Test Case]
>
> Boot platform and bring up "oob_net0" interface properly
> Test that network traffic works properly
>
> [Regression Potential]
>
> Low, as the patch was reviewed upstream
>
> [Other]
>
> None
>
> Peng Wu (1):
>   net/mlxbf_gige: Fix an IS_ERR() vs NULL bug in mlxbf_gige_mdio_probe
>
>  drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.30.1



More information about the kernel-team mailing list