[SRU][F:linux-bluefield][Pull Request][v2]: i2c-mlxbf.c: Sync up driver with upstreaming

Asmaa Mnebhi asmaa at nvidia.com
Wed Oct 5 12:26:55 UTC 2022


Will do! Thanks Stefan!

-----Original Message-----
From: Stefan Bader <stefan.bader at canonical.com> 
Sent: Wednesday, October 5, 2022 3:43 AM
To: Asmaa Mnebhi <asmaa at nvidia.com>; kernel-team at lists.ubuntu.com
Cc: Vladimir Sokolovsky <vlad at nvidia.com>; Meriton Tuli <meriton at nvidia.com>; Khoa Vo <khoav at nvidia.com>
Subject: Re: [SRU][F:linux-bluefield][Pull Request][v2]: i2c-mlxbf.c: Sync up driver with upstreaming

On 04.10.22 19:48, Asmaa Mnebhi wrote:
> This pull request (25 commits) includes reverting 8 i2c-mlxbf.c 
> commits in Focal linux-bluefield. Then it cherry-picks 16 i2c-mlxbf.c 
> related commits from linux-next master branch.
> 
> BugLink: https://bugs.launchpad.net/bugs/1991551
> 
> This pull request page can be found at:
> 
> https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git
> /version-seeds-2/+merge/430985
> 
> Git repo can be found at:
> 
> git+ssh://asmaam@git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefi
> git+eld/+git/version-seeds-2 master-next
> 
> for you to fetch changes starting from commit 
> 5e92e369bc16d2ad686198a6ecffe7eff5c0f15c
> 
> Revert "UBUNTU: SAUCE: i2c-mlxbf.c: support lock mechanism"
> 
> Signed-off-by: Asmaa Mnebhi <asmaa at nvidia.com>

As a suggestion for future cases where things apply to both series: this could be submitted as one thread like:

[SRU][F/J:linux-bluefield]: i2c-mlxbf.c: Sync up with upstream driver
   -> the cover email

   * [SRU][J:linux-bluefield][Pull Request]: i2c-mlxbf.c: Sync up driver with
     upstreaming
     -> the jammy pull request
   * [SRU][F:linux-bluefield][Pull Request]: i2c-mlxbf.c: Sync up driver with
     upstreaming
     -> the focal one

Likewise if it were single patches it could have the jammy and focal variants following (or single patches if those apply to both series).

I would use the rule of thumb that if something is under the same bug report it should also be a single submission.

-Stefan

> 
> Asmaa Mnebhi (17):
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: support lock mechanism"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: fix wrong variable name"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: remove IRQF_ONESHOT flag"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: prevent stack overflow in
>      mlxbf_i2c_smbus_start_transaction()"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: revert upstreaming version"
>    Revert "UBUNTU: SAUCE: Syncup i2c-mlx driver with upstreamed version"
>    Revert "UBUNTU: SAUCE: i2c-mlx.c: Fix core frequency"
>    Revert "UBUNTU: SAUCE: i2c: i2c-mlx: I2C SMBus driver for Mellanox
>      BlueField SoC"
>    i2c: mlxbf: incorrect base address passed during io write
>    i2c: mlxbf: prevent stack overflow in
>      mlxbf_i2c_smbus_start_transaction()
>    i2c: mlxbf: Fix frequency calculation
>    i2c: mlxbf: remove IRQF_ONESHOT
>    i2c: mlxbf: support lock mechanism
>    i2c: mlxbf: add multi slave functionality
>    i2c: mlxbf: support BlueField-3 SoC
>    i2c: mlxbf: remove device tree support
>    UBUNTU: SAUCE: i2c-mlxbf.c: Add driver version
> 
> Khalil Blaiech (6):
>    i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC
>    i2c: mlxbf: Add CONFIG_ACPI to guard ACPI function call
>    i2c: mlxbf: Fix resrticted cast warning of sparse
>    i2c: mlxbf: Remove unecessary wrapper functions
>    i2c: mlxbf: Update reference clock frequency
>    i2c: mlxbf: Update author and maintainer email info
> 
> Sergey Shtylyov (1):
>    i2c: mlxbf: add IRQ check
> 
> Wang Xiaojun (1):
>    i2c: mlxbf: Fix the return check of devm_ioremap and ioremap
> 
>   .../devicetree/bindings/i2c/i2c-mlx.txt       |   42 +
>   .../bindings/i2c/mellanox,i2c-mlxbf.yaml      |   78 -
>   MAINTAINERS                                   |    7 +
>   debian.bluefield/config/config.common.ubuntu  |    2 +-
>   drivers/i2c/busses/Kconfig                    |    5 +-
>   drivers/i2c/busses/Makefile                   |    2 +-
>   drivers/i2c/busses/i2c-mlxbf.c                | 2613 ++++++++---------
>   7 files changed, 1332 insertions(+), 1417 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mlx.txt
>   delete mode 100644 
> Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
> 



More information about the kernel-team mailing list