ACK: [SRU][F:linux-bluefield][PATCH v1 0/1] mlxbf_gige: remove driver-managed interrupt counts

Tim Gardner tim.gardner at canonical.com
Thu May 26 12:28:45 UTC 2022


Acked-by: Tim Gardner <tim.gardner at canonical.com>

On 5/25/22 16:04, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/1975749
> 
> SRU Justification:
> 
> [Impact]
> 
> The mlxbf_gige driver currently has three driver-managed
> interrupt counts that increment each time every interrupt
> handler executes. This has been reviewed and found to be
> unnecessary given core logic in Linux kernel manages the
> same information.
> 
> [Fix]
> 
> The fix is to remove the driver-managed interrupt counts
> from the driver itself, and let the core handle it.
> There is an upstream commit already that makes this change.
> 
> [Test Case]
> 
> The driver should function as before, specifically:
> * driver probes successfully
> * oob_net0 link comes up, as seen with "ifconfig -a"
> 
> [Regression Potential]
> 
> This change only affects counters that are visible inside
> driver, so thus should not introduce any regression.
> 
> David Thompson (1):
>    mlxbf_gige: remove driver-managed interrupt counts
> 
>   drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h    | 3 ---
>   .../ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c    | 8 +++-----
>   .../net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_intr.c   | 9 ---------
>   3 files changed, 3 insertions(+), 17 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list