[SRU][F:linux-bluefield][PATCH v1 0/1] mlxbf_gige: remove driver-managed interrupt counts

David Thompson davthompson at nvidia.com
Wed May 25 22:04:21 UTC 2022


BugLink: https://bugs.launchpad.net/bugs/1975749

SRU Justification:

[Impact]

The mlxbf_gige driver currently has three driver-managed
interrupt counts that increment each time every interrupt
handler executes. This has been reviewed and found to be
unnecessary given core logic in Linux kernel manages the
same information.

[Fix]

The fix is to remove the driver-managed interrupt counts
from the driver itself, and let the core handle it.
There is an upstream commit already that makes this change.

[Test Case]

The driver should function as before, specifically:
* driver probes successfully
* oob_net0 link comes up, as seen with "ifconfig -a"

[Regression Potential]

This change only affects counters that are visible inside
driver, so thus should not introduce any regression.

David Thompson (1):
  mlxbf_gige: remove driver-managed interrupt counts

 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h    | 3 ---
 .../ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c    | 8 +++-----
 .../net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_intr.c   | 9 ---------
 3 files changed, 3 insertions(+), 17 deletions(-)

-- 
2.30.1




More information about the kernel-team mailing list