NACK+Cmnt: [PATCH 0/2 v2] [HI:linux] CONFIG_SPEAKUP=y

[Tim Gardner]

v3 on the list

On 9/9/21 12:56 PM, Thadeu Lima de Souza Cascardo wrote:
> On Thu, Sep 09, 2021 at 12:15:27PM -0600, Tim Gardner wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1942459
>>
>> v2 - removed extraneous compiler version updates from Impish patch.
>>       added CONFIG_SPEAKUP to annotations.
>>       expanded on the history of CONFIG_SPEAKUP in commit message.
>>       disabled CONFIG_A11Y_BRAILLE_CONSOLE as not pertinent to the bug report.
> 
> 
> Hey, Tim.
> 
> Sorry for not making it clear on the other message, but s390x was not on
> the list of architectures where CONFIG_SPEAKUP was on before 5.11. As a
> policy, we don't enable things by default on s390x.
> 

Disabled for s390x

> On the other hand, A11Y_BRAILLE_CONSOLE has been available and disabled at
> least since xenial (because it depends on ACCESSIBILITY, which has been
> disabled at least ever since).
> 
> Though I wonder whether we should change that and enable it, we should
> leave it for another patchset in the future.
> 

I chose to leave it disabled until someone requests it.

> Also, notice that your commits are missing the BugLink lines, though it is
> present in the cover letter.
> 

Doh! restored...

rtg
-----------
Tim Gardner
Canonical, Inc