NACK+Cmnt: [PATCH 0/2 v2] [HI:linux] CONFIG_SPEAKUP=y

[Thadeu Lima de Souza Cascardo]

On Thu, Sep 09, 2021 at 12:15:27PM -0600, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1942459
> 
> v2 - removed extraneous compiler version updates from Impish patch.
>      added CONFIG_SPEAKUP to annotations.
>      expanded on the history of CONFIG_SPEAKUP in commit message.
>      disabled CONFIG_A11Y_BRAILLE_CONSOLE as not pertinent to the bug report.


Hey, Tim.

Sorry for not making it clear on the other message, but s390x was not on
the list of architectures where CONFIG_SPEAKUP was on before 5.11. As a
policy, we don't enable things by default on s390x.

On the other hand, A11Y_BRAILLE_CONSOLE has been available and disabled at
least since xenial (because it depends on ACCESSIBILITY, which has been
disabled at least ever since).

Though I wonder whether we should change that and enable it, we should
leave it for another patchset in the future.

Also, notice that your commits are missing the BugLink lines, though it is
present in the cover letter.

Thanks again.
Cascardo.

> 
> SRU Justification
> 
> [Impact]
> 
> No speakup accessibility modules are available in linux-generic.
> 
> [Fix]
> 
> CONFIG_ACCESSIBILITY=y
> CONFIG_SPEAKUP=m
> 
> [Test Plan]
> 
> Unpack linux-modules-extra and check for speakup modules.
> 
> [Where problems could occur]
> 
> Enabling CONFIG_ACCESSIBILITY=y could affect console output.
> 
> [Other Info]
> 
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team