NAK: [SRU][H, I][PATCH 0/2] cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline

Tim Gardner tim.gardner at canonical.com
Tue Nov 16 12:38:46 UTC 2021


Commit dbea75fe18f60e364de6d994fc938a24ba249d81 is a clean cherry-pick 
to both repos. We only use 'backported' when there is a conflict. As 
Stefan mentioned, always provide a brief description of the conflict 
resolution after your S-O-B. Otherwise 'git cherry-pick -s -x' leaves 
the right info in the patch, though you still have to add the BugLink. 
See kteam-tools/maintscripts/maint-modify-patch for that.

When sending version 2 be sure to note that in the subject, e.g., " 
[SRU][H, I][PATCH 0/2 v2] cpufreq: intel_pstate: Clear HWP desired on 
suspend/shutdown and offline".

As with an upstream patch, note in the patch description what the 
changes were from v1-->v2.

rtg

On 11/15/21 11:43 AM, Philip Cox wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki at intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1950584
> 
> [Impact]
> 
> "Commit a365ab6b9dfb ("cpufreq: intel_pstate: Implement the
>   ->adjust_perf() callback") caused intel_pstate to use nonzero HWP
>   desired values in certain usage scenarios, but it did not prevent
>   them from being leaked into the confugirations in which HWP desired
>   is expected to be 0"
> 
> I believe I'm seeing this issue on my laptop during suspend/resume. The upstream fix is:
> 
> commit dbea75fe18f60e364de6d994fc938a24ba249d81
> Author: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> Date: Wed Nov 3 19:43:47 2021 +0100
> 
>      cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> [Fix]
> 
> dbea75fe18f60e364de6d994fc938a24ba249d81 cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list