ACK/cmnt: [SRU][H, I][PATCH 0/2] cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline

[Kleber Souza]

On 15.11.21 19:43, Philip Cox wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki at intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1950584
> 
> [Impact]
> 
> "Commit a365ab6b9dfb ("cpufreq: intel_pstate: Implement the
>   ->adjust_perf() callback") caused intel_pstate to use nonzero HWP
>   desired values in certain usage scenarios, but it did not prevent
>   them from being leaked into the confugirations in which HWP desired
>   is expected to be 0"
> 
> I believe I'm seeing this issue on my laptop during suspend/resume. The upstream fix is:
> 
> commit dbea75fe18f60e364de6d994fc938a24ba249d81
> Author: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> Date: Wed Nov 3 19:43:47 2021 +0100
> 
>      cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> [Fix]
> 
> dbea75fe18f60e364de6d994fc938a24ba249d81 cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> 

The SRU template has a section "[Where problems could occur]" to be used
to describe what is the regression potential and how problems would show
up in case there are issues with this patch (please see [1]). You don't
need to resubmit the patchset to include it, but it would be nice to
have some quick analysis added to the launchpad bug report.

Apart from it there's also a typo in one of the patches that can be
fixed by the person applying the patch.


Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

Thanks!



[1] https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template