APPLIED[B/F]/cmnt: [SRU Bionic/Focal/Hirsute/Impish 0/2] LP: #1947161 - ACL updates on OCFS2 are not revalidated

Stefan Bader stefan.bader at canonical.com
Fri Nov 5 08:30:54 UTC 2021


On 04.11.21 18:43, Thadeu Lima de Souza Cascardo wrote:
> On Thu, Nov 04, 2021 at 05:30:53PM +0100, Kleber Souza wrote:
>> On 14.10.21 15:51, Thadeu Lima de Souza Cascardo wrote:
>>> https://bugs.launchpad.net/bugs/1947161
>>>
>>> [Impact]
>>> When ACLs are updated on OCFS2, their caches are not revalidated, requiring remounts to be able to see the updates.
>>>
>>> [Fix]
>>> Upstream commits:
>>> 504ec37dfdfbf9c65166c51f7b12126d2a9b18dc ("ocfs2: fix remounting needed after setfacl command")
>>> 9c0f0a03e386f4e1df33db676401547e1b7800c6 ("ocfs2: drop acl cache for directories too")
>>>
>>> [Test case]
>>> On a single node:
>>> setfacl -m u:user1:rwX dir1
>>> getfacl dir1
>>>
>>> On multiple nodes:
>>> Node1:
>>> getfacl dir1
>>>
>>> Node2:
>>> getfacl dir1
>>>
>>> Node1:
>>> setfacl -m u:user1:rwX dir1
>>> getfacl dir1
>>>
>>> Node2:
>>> getfacl dir1
>>>
>>> [Potential regression]
>>> ACL changes on OCFS2 may stop working properly.
>>>
>>> Gang He (1):
>>>     ocfs2: fix remounting needed after setfacl command
>>>
>>> Wengang Wang (1):
>>>     ocfs2: drop acl cache for directories too
>>>
>>>    fs/ocfs2/acl.c     | 2 ++
>>>    fs/ocfs2/dlmglue.c | 3 ++-
>>>    2 files changed, 4 insertions(+), 1 deletion(-)
>>>
>>
>>
>> Applied patch 1/2 to [bionic/focal]:linux.
>>
>> Patch 2/2 had already been applied to all four series as part of upstream
>> stable updates.
> 
> Can you please add the BugLink to those commits? Whenever we drop patches
> specifically submitted for a bug in favor of an upstream stable update, we fail
> to notify users who asked for that bug about them being applied and waiting for
> verification.

Ok, I added the correct reference to all involved patches (also fixing up the 
ones applied to B/F since they missed the BugLink key).

-Stefan
> 
> Cascardo.
> 
>>
>>
>> Thanks,
>> Kleber
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20211105/0113732b/attachment.sig>


More information about the kernel-team mailing list