NAK/Cmnt: [SRU][F:linux-bluefield][PATCH v2 1/1] UBUNTU: SAUCE: platform/mellanox: Add ctrl message and MAC configuration

[Liming Sun]

Thanks! Updated in v3.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> Sent: Thursday, May 6, 2021 7:40 AM
> To: Liming Sun <limings at nvidia.com>; kernel-team at lists.ubuntu.com
> Cc: Liming Sun <limings at nvidia.com>
> Subject: NAK/Cmnt: [SRU][F:linux-bluefield][PATCH v2 1/1] UBUNTU:
> SAUCE: platform/mellanox: Add ctrl message and MAC configuration
> 
> On 05/05/2021 15:06, Liming Sun wrote:
> > From: Liming Sun <lsun at mellanox.com>
> >
> > BugLink:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> .launchpad.net%2Fbugs%2F1927253&data=04%7C01%7Climings%40nvid
> ia.com%7C0e602a09a2934d8c711708d91083bc03%7C43083d15727340c1b7db3
> 9efd9ccc17a%7C0%7C0%7C637558980259545272%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C1000&sdata=PATUYxUYXb%2FV4s4Xi%2By6A6fPB1IOpfLTST%
> 2FsnmHc95c%3D&reserved=0
> >
> > This commit adds control message support and MAC configuration
> > based on the control message.
> >
> > Signed-off-by: Liming Sun <limings at nvidia.com>
> > ---
> >  drivers/platform/mellanox/mlxbf-tmfifo-regs.h |   4 +-
> >  drivers/platform/mellanox/mlxbf-tmfifo.c      | 180
> ++++++++++++++++++++++----
> >  2 files changed, 156 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/platform/mellanox/mlxbf-tmfifo-regs.h
> b/drivers/platform/mellanox/mlxbf-tmfifo-regs.h
> > index e4f0d2e..e680230 100644
> > --- a/drivers/platform/mellanox/mlxbf-tmfifo-regs.h
> > +++ b/drivers/platform/mellanox/mlxbf-tmfifo-regs.h
> > @@ -1,6 +1,6 @@
> > -/* SPDX-License-Identifier: GPL-2.0 */
> > +/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0-only */
> >  /*
> > - * Copyright (c) 2019, Mellanox Technologies. All rights reserved.
> > + * Copyright (c) 2020 NVIDIA Corporation. All rights reserved.
> >   */
> >
> >  #ifndef __MLXBF_TMFIFO_REGS_H__
> > diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c
> b/drivers/platform/mellanox/mlxbf-tmfifo.c
> > index 5739a966..b69ab33 100644
> > --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> > +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> > @@ -1,8 +1,8 @@
> > -// SPDX-License-Identifier: GPL-2.0+
> > +// SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0-only
> 
> The same as in your other patch - this looks unrelated to the change
> here, so should be separate commit.  Relicensing existing contribution
> is not that easy - you need other contributors or copyright holder
> signed-offs.
> 
> 
> Best regards,
> Krzysztof