NACK/CMT: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: platform/mellanox: Add ctrl message and MAC configuration

Kelsey Skunberg kelsey.skunberg at canonical.com
Thu May 6 04:53:33 UTC 2021


Hello Liming, 

Thank you for the patches.

When sending a v2, please send it as a new email instead of replying to
the original. This will help avoid confusion, is less prone for errors,
and doesn't run the same risk of getting lost in the mailing list. May
you please resend this?

In addition, for future patches you send a revision for, please `NACK`
the originals if it has not already been done. You can do this by
replying to the patch which is no longer valid and include `NACK` at the
beginning of the subject line as I have done with this response. 

Thanks again!

-Kelsey

On 2021-05-05 12:43:32 , Liming Sun wrote:
> BugLink: https://bugs.launchpad.net/bugs/1927253
> 
> SRU Justification:
> 
> [Impact]
> 
> * This is an enhancement to support ctrl message and BlueField side rshim
>   MAC address configuration from the rshim driver.
> 
> [Fix]
> 
> * Additional new code for the enhancement. It doesn't have fix for existing code.
> [Test Case]
> 
> * Set DISPLAY_LEVEL to 1 in /dev/rshim0/misc and do 'cat /dev/rshim0/misc'
>   from external rshim driver. The rshim MAC address will show up.
> * echo "PEER_MAC xx:xx:xx:xx:xx:xx" > /dev/rshim0/misc to modify
>   the MAC address. The change will take effect in next boot.
> 
> [Regression Potential]
> 
> * This version of the driver was tested by QA/verification for a while so no
>   known regression at the moment.
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list