NACK: [SRU][PATCH v3][F/oracle][PULL] arm64 support (LP: #1925421)
Juerg Haefliger
juerg.haefliger at canonical.com
Sat May 1 07:11:49 UTC 2021
On Fri, 30 Apr 2021 13:32:09 -0400
Khaled Elmously <khalid.elmously at canonical.com> wrote:
> On 2021-04-30 14:01:28 , Juerg Haefliger wrote:
> > Sorry.
> >
> > 1) genconfigs doesn't pass with only the first commit (UBUNTU: [config] oracle:
> > Bring-up for arm64 support) applied.
>
> That is because of the rebase, not because of the arm64 changes. They are annotation failures from master, unrelated to arm64, so in other words, even without the arm64 changes genconfigs fails.
> I moved the annotation fix-up so it is the first commit after the rebase.
Oh. So in this case these changes are completely unrelated to this PR and
shouldn't be part of the PR at all. These are required changes due to our
process and don't need to go through the ML. Why are you rebasing anyways?
That's the job of the cranker not the patch preparer/submitter. You're
supposed to checkout origin/master-next, apply your patches and create the PR.
No rebase during this process. You don't know what the state of master-next is
by the time the PR is applied so rebasing is not doing you any good.
Hold on. That's not even true. These annotations are required because your
introducing a new architecture. Has nothing to do with any rebase. So they are
due to this PR and need to be squashed into the initial commit that introduces
that new architecture.
And what rebase? You're starting from 1044.47 in proposed which is already
up-to-date and a rebase is doing nothing. I'm utterly confused about your
process...
>
> >
> > 2) git show aea1f691e955..543efa4b34a4 | grep github
> > (backported from https://github.com/AmpereComputing/ampere-centos-kernel/commit/19a1b3868b040d9c444719eccc6ede39e5bd0857)
> > (cherry picked from c015bb2eebcb97a2dfbf656f63449807e469e342 https://github.com/AmpereComputing/ampere-centos-kernel)
> > (backported from f2e6dee522cc4be9dd094c30dc88273f44d5ffe2 https://github.com/AmpereComputing/ampere-centos-kernel)
> > (cherry picked from commit d6f5dfc8aaefa8e13b03f47d44590bef4460a7d9 https://github.com/AmpereComputing/ampere-centos-kernel)
> > (cherry picked from commit 1164351241b52b3c8ffab4e29de5f93a9abe4acf https://github.com/AmpereComputing/ampere-centos-kernel)
>
> Done.
Thanks.
> >
> > 3) (cherry picked from commit 3256ff83c566235e812498ee1dc806c45a5d5af7)
> > [kmously: context changes (number of args to memmap_init_zone,
> > and line ordering in mm.h) ]
>
> Done.
Thanks.
> >
> > Additionally the following but I don't care too much. It's up to you, if you
> > want to 'fix' that as well.
> >
> > - Capital C in "UBUNTU: [Config] oracle:"
> > - Options in arm64.mk are not in same order as in amd64.mk.
>
> Done.
Done as in ignored? I don't see these chagnes in v4. But as I said, I'm ok with
not fixing that.
...Juerg
> >
> > ...Juerg
> >
> > > The following changes since commit aea1f691e9550b653072cf0931afeafebd4fab67:
> > >
> > > UBUNTU: Ubuntu-oracle-5.4.0-1044.47 (2021-04-19 11:18:25 -0600)
> > >
> > > are available in the Git repository at:
> > >
> > > git+ssh://git.launchpad.net/~kmously/ubuntu/+source/linux/+git/focal tags/oracle-arm-19
> > >
> > > for you to fetch changes up to 543efa4b34a40d9c22927c1f573d41f4c9bc1243:
> > >
> > > UBUNTU: [config] oracle: update annotations (2021-04-30 06:00:28 -0400)
> > >
> > > ----------------------------------------------------------------
> > > Baoquan He (3):
> > > mm: memmap_init: iterate over memblock regions rather that check each PFN
> > > mm: rename memmap_init() and memmap_init_zone()
> > > mm: simplify parater of function memmap_init_zone()
> > >
> > > David Hildenbrand (2):
> > > mm/page_alloc.c: initialize memmap of unavailable memory directly
> > > mm: pass migratetype into memmap_init_zone() and move_pfn_range_to_zone()
> > >
> > > James Morse (2):
> > > mm/memory-failure: Add memory_failure_queue_kick()
> > > ACPI: APEI: Kick the memory_failure() queue for synchronous errors
> > >
> > > Khalid Elmously (3):
> > > UBUNTU: [config] oracle: Bring-up for arm64 support
> > > UBUNTU: [config] oracle: update configs
> > > UBUNTU: [config] oracle: update annotations
> > >
> > > Mike Rapoport (22):
> > > mm: memblock: replace dereferences of memblock_region.nid with API calls
> > > mm: make early_pfn_to_nid() and related defintions close to each other
> > > mm: remove CONFIG_HAVE_MEMBLOCK_NODE_MAP option
> > > mm: free_area_init: use maximal zone PFNs rather than zone sizes
> > > mm: use free_area_init() instead of free_area_init_nodes()
> > > alpha: simplify detection of memory zone boundaries
> > > arm: simplify detection of memory zone boundaries
> > > arm64: simplify detection of memory zone boundaries for UMA configs
> > > csky: simplify detection of memory zone boundaries
> > > m68k: mm: simplify detection of memory zone boundaries
> > > parisc: simplify detection of memory zone boundaries
> > > sparc32: simplify detection of memory zone boundaries
> > > unicore32: simplify detection of memory zone boundaries
> > > xtensa: simplify detection of memory zone boundaries
> > > mm/page_alloc.c: refactor initialization of struct page for holes in memory layout
> > > mm: remove early_pfn_in_nid() and CONFIG_NODES_SPAN_OTHER_NODES
> > > mm: free_area_init: allow defining max_zone_pfn in descending order
> > > arc: fix memory initialization for systems with two memory banks
> > > mm: rename free_area_init_node() to free_area_init_memoryless_node()
> > > mm: clean up free_area_init_node() and its helpers
> > > mm: simplify find_min_pfn_with_active_regions()
> > > docs/vm: update memory-models documentation
> > >
> > > Robin Murphy (4):
> > > perf: Add Arm CMN-600 PMU driver
> > > perf: Add Arm CMN-600 DT binding
> > > perf/arm-cmn: Fix PMU instance naming
> > > perf/arm-cmn: Move IRQs when migrating context
> > >
> > > Tuan Phan (7):
> > > UBUNTU: SAUCE: perf/smmuv3: Allow sharing MMIO registers with the SMMU driver
> > > UBUNTU: SAUCE: arm64: Split the old READ_IMPLIES_EXEC workaround from executable
> > > PCI/ACPI: Add Ampere Altra SOC MCFG quirk
> > > driver/perf: Add PMU driver for the ARM DMC-620 memory controller
> > > perf: arm_dsu: Support DSU ACPI devices
> > > UBUNTU: SAUCE: perf: arm_dsu: Allow IRQ to be shared among devices.
> > > Perf: arm-cmn: Allow irq to be shared.
> > >
> > > Vanshidhar Konda (1):
> > > arm64: NUMA: Kconfig: Increase NODES_SHIFT to 4
> > >
> > > Wei Yongjun (1):
> > > perf/arm_dmc620_pmu: Fix error return code in dmc620_pmu_device_probe()
> > >
> > > Will Deacon (1):
> > > perf: arm-cmn: Fix unsigned comparison to less than zero
> > >
> > > lho (1):
> > > UBUNTU: SAUCE: hwmon: Add Ampere Altra HW monitor driver
> > >
> > > Documentation/admin-guide/perf/arm-cmn.rst | 65 +
> > > Documentation/admin-guide/perf/index.rst | 1 +
> > > .../devicetree/bindings/perf/arm,cmn.yaml | 57 +
> > > .../features/vm/numa-memblock/arch-support.txt | 34 -
> > > Documentation/vm/memory-model.rst | 9 +-
> > > arch/alpha/mm/init.c | 16 +-
> > > arch/alpha/mm/numa.c | 22 +-
> > > arch/arc/mm/init.c | 66 +-
> > > arch/arm/kernel/elf.c | 27 +-
> > > arch/arm/mm/init.c | 66 +-
> > > arch/arm64/Kconfig | 3 +-
> > > arch/arm64/include/asm/elf.h | 23 +-
> > > arch/arm64/mm/init.c | 48 +-
> > > arch/arm64/mm/numa.c | 9 +-
> > > arch/c6x/mm/init.c | 8 +-
> > > arch/csky/kernel/setup.c | 26 +-
> > > arch/h8300/mm/init.c | 6 +-
> > > arch/hexagon/mm/init.c | 6 +-
> > > arch/ia64/Kconfig | 1 -
> > > arch/ia64/mm/contig.c | 2 +-
> > > arch/ia64/mm/discontig.c | 2 +-
> > > arch/ia64/mm/init.c | 4 +-
> > > arch/m68k/mm/init.c | 6 +-
> > > arch/m68k/mm/mcfmmu.c | 9 +-
> > > arch/m68k/mm/motorola.c | 15 +-
> > > arch/m68k/mm/sun3mmu.c | 10 +-
> > > arch/microblaze/Kconfig | 1 -
> > > arch/microblaze/mm/init.c | 2 +-
> > > arch/mips/Kconfig | 1 -
> > > arch/mips/mm/init.c | 2 +-
> > > arch/mips/sgi-ip27/ip27-memory.c | 2 +-
> > > arch/nds32/mm/init.c | 11 +-
> > > arch/nios2/mm/init.c | 8 +-
> > > arch/openrisc/mm/init.c | 9 +-
> > > arch/parisc/mm/init.c | 22 +-
> > > arch/powerpc/Kconfig | 10 -
> > > arch/powerpc/mm/mem.c | 2 +-
> > > arch/riscv/Kconfig | 1 -
> > > arch/riscv/mm/init.c | 2 +-
> > > arch/s390/Kconfig | 1 -
> > > arch/s390/mm/init.c | 2 +-
> > > arch/sh/Kconfig | 1 -
> > > arch/sh/mm/init.c | 2 +-
> > > arch/sparc/Kconfig | 10 -
> > > arch/sparc/mm/init_64.c | 2 +-
> > > arch/sparc/mm/srmmu.c | 21 +-
> > > arch/um/kernel/mem.c | 12 +-
> > > arch/unicore32/include/asm/memory.h | 2 +-
> > > arch/unicore32/include/mach/memory.h | 6 +-
> > > arch/unicore32/kernel/pci.c | 14 +-
> > > arch/unicore32/mm/init.c | 43 +-
> > > arch/x86/Kconfig | 10 -
> > > arch/x86/include/asm/elf.h | 22 +-
> > > arch/x86/mm/init.c | 2 +-
> > > arch/x86/mm/numa.c | 11 +-
> > > arch/xtensa/mm/init.c | 8 +-
> > > debian.oracle/abi/5.4.0-1039.42/arm64/ignore | 0
> > > .../abi/5.4.0-1039.42/arm64/ignore.modules | 0
> > > .../abi/5.4.0-1039.42/arm64/ignore.retpoline | 0
> > > debian.oracle/abi/5.4.0-1043.46/arm64/ignore | 1 +
> > > .../abi/5.4.0-1043.46/arm64/ignore.compiler | 1 +
> > > .../abi/5.4.0-1043.46/arm64/ignore.modules | 1 +
> > > .../abi/5.4.0-1043.46/arm64/ignore.retpoline | 1 +
> > > debian.oracle/config/amd64/config.common.amd64 | 24 +
> > > debian.oracle/config/annotations | 22 +-
> > > debian.oracle/config/arm64/config.common.arm64 | 27 +
> > > debian.oracle/config/arm64/config.flavour.oracle | 3 +
> > > debian.oracle/config/config.common.ubuntu | 660 +++++++-
> > > debian.oracle/control.d/vars.oracle | 4 +-
> > > debian.oracle/control.stub.in | 2 +-
> > > debian.oracle/etc/kernelconfig | 2 +-
> > > debian.oracle/rules.d/arm64.mk | 30 +
> > > drivers/acpi/apei/ghes.c | 67 +-
> > > drivers/acpi/pci_mcfg.c | 20 +
> > > drivers/hwmon/Kconfig | 10 +
> > > drivers/hwmon/Makefile | 1 +
> > > drivers/hwmon/altra-hwmon.c | 435 ++++++
> > > drivers/iommu/arm-smmu-v3.c | 2 +-
> > > drivers/pci/ecam.c | 10 +
> > > drivers/perf/Kconfig | 14 +
> > > drivers/perf/Makefile | 2 +
> > > drivers/perf/arm-cmn.c | 1638 ++++++++++++++++++++
> > > drivers/perf/arm_dmc620_pmu.c | 749 +++++++++
> > > drivers/perf/arm_dsu_pmu.c | 65 +-
> > > drivers/perf/arm_smmuv3_pmu.c | 25 +-
> > > fs/compat_binfmt_elf.c | 5 +
> > > include/acpi/ghes.h | 3 +
> > > include/linux/memblock.h | 8 +-
> > > include/linux/memory_hotplug.h | 3 +-
> > > include/linux/mm.h | 44 +-
> > > include/linux/mmzone.h | 11 +-
> > > include/linux/pci-ecam.h | 1 +
> > > mm/Kconfig | 3 -
> > > mm/compaction.c | 4 +-
> > > mm/memblock.c | 19 +-
> > > mm/memory-failure.c | 15 +-
> > > mm/memory_hotplug.c | 17 +-
> > > mm/memremap.c | 3 +-
> > > mm/page_alloc.c | 420 +++--
> > > 99 files changed, 4343 insertions(+), 812 deletions(-)
> > > create mode 100644 Documentation/admin-guide/perf/arm-cmn.rst
> > > create mode 100644 Documentation/devicetree/bindings/perf/arm,cmn.yaml
> > > delete mode 100644 Documentation/features/vm/numa-memblock/arch-support.txt
> > > create mode 100644 debian.oracle/abi/5.4.0-1039.42/arm64/ignore
> > > create mode 100644 debian.oracle/abi/5.4.0-1039.42/arm64/ignore.modules
> > > create mode 100644 debian.oracle/abi/5.4.0-1039.42/arm64/ignore.retpoline
> > > create mode 100644 debian.oracle/abi/5.4.0-1043.46/arm64/ignore
> > > create mode 100644 debian.oracle/abi/5.4.0-1043.46/arm64/ignore.compiler
> > > create mode 100644 debian.oracle/abi/5.4.0-1043.46/arm64/ignore.modules
> > > create mode 100644 debian.oracle/abi/5.4.0-1043.46/arm64/ignore.retpoline
> > > create mode 100644 debian.oracle/config/arm64/config.common.arm64
> > > create mode 100644 debian.oracle/config/arm64/config.flavour.oracle
> > > create mode 100644 debian.oracle/rules.d/arm64.mk
> > > create mode 100644 drivers/hwmon/altra-hwmon.c
> > > create mode 100644 drivers/perf/arm-cmn.c
> > > create mode 100644 drivers/perf/arm_dmc620_pmu.c
> > >
> >
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210501/573df3b8/attachment.sig>
More information about the kernel-team
mailing list