[OEM-5.10/OEM-5.13] [PATCH 07/17] nvme-pci: look for StorageD3Enable on companion ACPI device instead

Kai-Heng Feng kai.heng.feng at canonical.com
Tue Jun 22 17:23:42 UTC 2021

From: Mario Limonciello <mario.limonciello at amd.com>

BugLink: https://bugs.launchpad.net/bugs/1932577                                                     

The documentation around the StorageD3Enable property hints that it
should be made on the PCI device.  This is where newer AMD systems set
the property and it's required for S0i3 support.

So rather than look for nodes of the root port only present on Intel
systems, switch to the companion ACPI device for all systems.
David Box from Intel indicated this should work on Intel as well.

Link: https://lore.kernel.org/linux-nvme/YK6gmAWqaRmvpJXb@google.com/T/#m900552229fa455867ee29c33b854845fce80ba70
Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro
Fixes: df4f9bc4fb9c ("nvme-pci: add support for ACPI StorageD3Enable property")
Suggested-by: Liang Prike <Prike.Liang at amd.com>
Acked-by: Raul E Rangel <rrangel at chromium.org>
Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
Reviewed-by: David E. Box <david.e.box at linux.intel.com>
Signed-off-by: Christoph Hellwig <hch at lst.de>
(cherry picked from commit e21e0243e7b0f1c2a21d21f4d115f7b37175772a linux-next)
Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
 drivers/nvme/host/pci.c | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c1f3446216c5..bcfd2878d022 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2836,10 +2836,7 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
 static bool nvme_acpi_storage_d3(struct pci_dev *dev)
-	struct acpi_device *adev;
-	struct pci_dev *root;
-	acpi_handle handle;
-	acpi_status status;
+	struct acpi_device *adev = ACPI_COMPANION(&dev->dev);
 	u8 val;
@@ -2847,28 +2844,9 @@ static bool nvme_acpi_storage_d3(struct pci_dev *dev)
 	 * must use D3 to support deep platform power savings during
 	 * suspend-to-idle.
-	root = pcie_find_root_port(dev);
-	if (!root)
-		return false;
-	adev = ACPI_COMPANION(&root->dev);
 	if (!adev)
 		return false;
-	/*
-	 * The property is defined in the PXSX device for South complex ports
-	 * and in the PEGP device for North complex ports.
-	 */
-	status = acpi_get_handle(adev->handle, "PXSX", &handle);
-	if (ACPI_FAILURE(status)) {
-		status = acpi_get_handle(adev->handle, "PEGP", &handle);
-		if (ACPI_FAILURE(status))
-			return false;
-	}
-	if (acpi_bus_get_device(handle, &adev))
-		return false;
 	if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable",
 		return false;

More information about the kernel-team mailing list