[OEM-5.10] [PATCH 06/17] Revert "UBUNTU: SAUCE: usb: pci-quirks: disable D3cold on AMD xhci suspend for s2idle"
Kai-Heng Feng
kai.heng.feng at canonical.com
Tue Jun 22 17:23:41 UTC 2021
BugLink: https://bugs.launchpad.net/bugs/1932577
This reverts commit 490a3119829ff39319068b67215d5b4760114c2b.
Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
---
drivers/usb/host/xhci-pci.c | 6 +-----
drivers/usb/host/xhci.h | 1 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 9c5c31117a4f..9568b907fd05 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -182,10 +182,6 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
(pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_1)))
xhci->quirks |= XHCI_U2_DISABLE_WAKE;
- if (pdev->vendor == PCI_VENDOR_ID_AMD &&
- pdev->device == 0x1639)
- xhci->quirks |= XHCI_AMD_S2IDL_SUPPORT_QUIRK;
-
if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
xhci->quirks |= XHCI_LPM_SUPPORT;
xhci->quirks |= XHCI_INTEL_HOST;
@@ -552,7 +548,7 @@ static int xhci_pci_suspend(struct usb_hcd *hcd, bool do_wakeup)
* Systems with the TI redriver that loses port status change events
* need to have the registers polled during D3, so avoid D3cold.
*/
- if (xhci->quirks & (XHCI_COMP_MODE_QUIRK | XHCI_AMD_S2IDL_SUPPORT_QUIRK))
+ if (xhci->quirks & XHCI_COMP_MODE_QUIRK)
pci_d3cold_disable(pdev);
if (xhci->quirks & XHCI_PME_STUCK_QUIRK)
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index a931d4604423..d01241f1daf3 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1880,7 +1880,6 @@ struct xhci_hcd {
#define XHCI_DISABLE_SPARSE BIT_ULL(38)
#define XHCI_SG_TRB_CACHE_SIZE_QUIRK BIT_ULL(39)
#define XHCI_NO_SOFT_RETRY BIT_ULL(40)
-#define XHCI_AMD_S2IDL_SUPPORT_QUIRK BIT_ULL(41)
unsigned int num_active_eps;
unsigned int limit_active_eps;
--
2.31.1
More information about the kernel-team
mailing list