[EXT] NACK: [SRU] [Focal] [PULL] [PATCH v2 0/4] qla2xxx: bug fixes

[Nilesh Javali]

Tim and Krzysztof,

Thanks for the review.
I will post the v3 with the suggested changes.

Thanks,
Nilesh

> -----Original Message-----
> From: Tim Gardner <tim.gardner at canonical.com>
> Sent: Tuesday, June 1, 2021 5:24 PM
> To: Nilesh Javali <njavali at marvell.com>; kernel-team at lists.ubuntu.com
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream at marvell.com>
> Subject: [EXT] NACK: [SRU] [Focal] [PULL] [PATCH v2 0/4] qla2xxx: bug fixes
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Nilesh - These patches look fine except for the commit log. Given
> that they are all clean cherry-picks from mainline, the 'backported'
> line is misleading. Please use 'git cherry-pick -s -x' when applying a
> patch. Change 'cherry picked' to 'backported' if there are merge
> conflicts that require a resolution.
> 
> Asking whomever applies these patches to modify the commit log manually
> is adding a bit of work (and extra things to remember).
> 
> Remember to add 'v2' in the cover letter patch when resubmitting.
> 
> rtg
> 
> On 5/28/21 4:42 AM, Nilesh Javali wrote:
> > BugLink: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__bugs.launchpad.net_bugs_1860724&d=DwICaQ&c=nKjWec2b6R0mOyP
> az7xtfQ&r=FAW9wuzbtHIZL7SV63sr8rG59Hctu-
> eGu0G9pxwOXgQ&m=hcM5temWoZlzLeK20tuCMrIrG7AbOYlRedFg2RYqIHY&
> s=8-7pzNuw7Q8GCSvVaCnx4iQT9PkZpxSBwQLIeVWgiis&e=
> >
> > SRU Justification:
> >
> > [Impact]
> >
> > * On Ubuntu 20.04, NVMe Target will not get discovered in N2N
> > * configuration. The discovery was failing because Initiator was
> > * trying FC PRLI instead of NVMe PRLI.
> >
> > [Fix]
> >
> > * The driver code changes to handle NVMe N2N configuration and send
> PRLI
> > * based on the target.
> >
> > [Test Plan]
> >
> > * Load driver in NVMe N2N configuration and NVMe devices should be
> > * discovered by an Initiator.
> >
> > [Where problems could occur]
> >
> > * NVMe N2N configuration.
> >
> > [Other Info]
> >
> > * The bug is with inbox qla2xxx driver and needs update.
> > * All the qla2xxx driver bug fixes are part of upstream kernel.
> > * The repo used is,
> > * https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__git.launchpad.net_-7Eubuntu-2Dkernel_ubuntu_-2Bsource_linux_-
> 2Bgit_focal&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FAW9wuzbtHIZL7S
> V63sr8rG59Hctu-
> eGu0G9pxwOXgQ&m=hcM5temWoZlzLeK20tuCMrIrG7AbOYlRedFg2RYqIHY&
> s=yRtX0h5Ne6_RMemccYBqFJnjxqmc3-5grcMgVFkR0xE&e=
> > * The base-commit used to apply these bug fixes is at the bottom.
> >
> > Arun Easi (1):
> >    scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue
> >
> > Quinn Tran (1):
> >    scsi: qla2xxx: Serialize fc_port alloc in N2N
> >
> > Quinn Trann (2):
> >    scsi: qla2xxx: Set Nport ID for N2N
> >    scsi: qla2xxx: Fix N2N and NVMe connect retry failure
> >
> >   drivers/scsi/qla2xxx/qla_def.h  |  2 +
> >   drivers/scsi/qla2xxx/qla_init.c | 68 ++++++++++++++++++++++++++-------
> >   drivers/scsi/qla2xxx/qla_mbx.c  | 47 ++++++++++++-----------
> >   drivers/scsi/qla2xxx/qla_os.c   | 10 +++--
> >   4 files changed, 88 insertions(+), 39 deletions(-)
> >
> >
> > base-commit: 7cb08860ffd3de2fe6eb3fb48afe12bd831d4755
> >
> 
> --
> -----------
> Tim Gardner
> Canonical, Inc