NACK: [SRU] [Focal] [PULL] [PATCH v2 0/4] qla2xxx: bug fixes

[Tim Gardner]

Hi Nilesh - These patches look fine except for the commit log. Given 
that they are all clean cherry-picks from mainline, the 'backported' 
line is misleading. Please use 'git cherry-pick -s -x' when applying a 
patch. Change 'cherry picked' to 'backported' if there are merge 
conflicts that require a resolution.

Asking whomever applies these patches to modify the commit log manually 
is adding a bit of work (and extra things to remember).

Remember to add 'v2' in the cover letter patch when resubmitting.

rtg

On 5/28/21 4:42 AM, Nilesh Javali wrote:
> BugLink: https://bugs.launchpad.net/bugs/1860724
> 
> SRU Justification:
> 
> [Impact]
> 
> * On Ubuntu 20.04, NVMe Target will not get discovered in N2N
> * configuration. The discovery was failing because Initiator was
> * trying FC PRLI instead of NVMe PRLI.
> 
> [Fix]
> 
> * The driver code changes to handle NVMe N2N configuration and send PRLI
> * based on the target.
> 
> [Test Plan]
> 
> * Load driver in NVMe N2N configuration and NVMe devices should be
> * discovered by an Initiator.
> 
> [Where problems could occur]
> 
> * NVMe N2N configuration.
> 
> [Other Info]
> 
> * The bug is with inbox qla2xxx driver and needs update.
> * All the qla2xxx driver bug fixes are part of upstream kernel.
> * The repo used is,
> * https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal
> * The base-commit used to apply these bug fixes is at the bottom.
> 
> Arun Easi (1):
>    scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue
> 
> Quinn Tran (1):
>    scsi: qla2xxx: Serialize fc_port alloc in N2N
> 
> Quinn Trann (2):
>    scsi: qla2xxx: Set Nport ID for N2N
>    scsi: qla2xxx: Fix N2N and NVMe connect retry failure
> 
>   drivers/scsi/qla2xxx/qla_def.h  |  2 +
>   drivers/scsi/qla2xxx/qla_init.c | 68 ++++++++++++++++++++++++++-------
>   drivers/scsi/qla2xxx/qla_mbx.c  | 47 ++++++++++++-----------
>   drivers/scsi/qla2xxx/qla_os.c   | 10 +++--
>   4 files changed, 88 insertions(+), 39 deletions(-)
> 
> 
> base-commit: 7cb08860ffd3de2fe6eb3fb48afe12bd831d4755
> 

-- 
-----------
Tim Gardner
Canonical, Inc