NACK/Cmnt: [PATCH 0/0] [F/H/I linux-aws] Enable AWS arm64 Nitro Enclave support

[Stefan Bader]

On 22.11.21 21:20, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1951873
> 
> These three pull requests constitute the entirety of the
> patches required to enable arm64 Nitro Enclave support for
> the supported AWS kernels. Note that amd64 has been enabled for some time.
> The patches beyond 'nitro_enclaves: Enable Arm64 support' are
> not strictly required, but having them will make future patches easier to apply
> given the amount of code formatting churn.
> 
> SRU Justification
> 
> [Impact]
> 
> Enable arm64 support for Nitro Enclaves
> 
> [Test Plan]
> 
> Boot an AWS arm64 instance. Test for the existence of enclaves.
> 
> [Where things could go wrong]
> 
> Its possible this could affect amd64 enclave support.
> 
> [Other Info]
> 
> SF: #00323459
> 
> ---------------------------------------------------------------- 
> ----------------------------------------------------------------
> 
> The following changes since commit 3bb0bb5db78f339ce10e9953910e3103085db838:
> 
>    UBUNTU: Ubuntu-aws-5.4.0-1060.63 (2021-11-12 11:19:16 -0700)
> 
> are available in the Git repository at:
> 
>    git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/focal
> 
> for you to fetch changes up to 6a6ddf2f5838a5b548b7036d9057c202a4494c92:
> 
>    nitro_enclaves: Add fixes for checkpatch blank line reports (2021-11-22 
> 13:00:47 -0700)
> 
> ----------------------------------------------------------------
> Andra Paraschiv (8):
>        nitro_enclaves: Fixup type and simplify logic of the poll mask setup
>        nitro_enclaves: Enable Arm64 support
>        nitro_enclaves: Update documentation for Arm64 support
>        nitro_enclaves: Add fix for the kernel-doc report
>        nitro_enclaves: Update copyright statement to include 2021
>        nitro_enclaves: Add fixes for checkpatch match open parenthesis reports
>        nitro_enclaves: Add fixes for checkpatch spell check reports
>        nitro_enclaves: Add fixes for checkpatch blank line reports
> 
> Longpeng(Mike) (1):
>        nitro_enclaves: Set Bus Master for the NE PCI device
> 
> Mathias Krause (1):
>        nitro_enclaves: Fix stale file descriptors on failed usercopy
> 
>   Documentation/virt/ne_overview.rst        | 21 ++++++----
>   drivers/virt/nitro_enclaves/Kconfig       |  8 +---
>   drivers/virt/nitro_enclaves/ne_misc_dev.c | 66 +++++++++++++------------------
>   drivers/virt/nitro_enclaves/ne_pci_dev.c  |  4 +-
>   drivers/virt/nitro_enclaves/ne_pci_dev.h  |  8 +++-
>   include/uapi/linux/nitro_enclaves.h       | 10 ++---
>   samples/nitro_enclaves/ne_ioctl_sample.c  |  7 ++--
>   7 files changed, 60 insertions(+), 64 deletions(-)
> 
> ---------------------------------------------------------------- 
> ----------------------------------------------------------------
> 
> The following changes since commit c1bd051414bd63bb6fba05a334b10a79897dd733:
> 
>    UBUNTU: Ubuntu-aws-5.11.0-1022.23 (2021-11-12 10:48:14 -0700)
> 
> are available in the Git repository at:
> 
>    git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/hirsute
> 
> for you to fetch changes up to 57ee76e2082d93668a8db7a9dcfd4e51963470a4:
> 
>    nitro_enclaves: Add fixes for checkpatch blank line reports (2021-11-22 
> 12:54:42 -0700)
> 
> ----------------------------------------------------------------
> Andra Paraschiv (7):
>        nitro_enclaves: Enable Arm64 support
>        nitro_enclaves: Update documentation for Arm64 support
>        nitro_enclaves: Add fix for the kernel-doc report
>        nitro_enclaves: Update copyright statement to include 2021
>        nitro_enclaves: Add fixes for checkpatch match open parenthesis reports
>        nitro_enclaves: Add fixes for checkpatch spell check reports
>        nitro_enclaves: Add fixes for checkpatch blank line reports
> 
> Longpeng(Mike) (1):
>        nitro_enclaves: Set Bus Master for the NE PCI device
> 
>   Documentation/virt/ne_overview.rst        | 21 +++++++++++++--------
>   drivers/virt/nitro_enclaves/Kconfig       |  8 ++------
>   drivers/virt/nitro_enclaves/ne_misc_dev.c | 17 +++++++++--------
>   drivers/virt/nitro_enclaves/ne_pci_dev.c  |  4 +++-
>   drivers/virt/nitro_enclaves/ne_pci_dev.h  |  8 ++++++--
>   include/uapi/linux/nitro_enclaves.h       | 10 +++++-----
>   samples/nitro_enclaves/ne_ioctl_sample.c  |  7 +++----
>   7 files changed, 41 insertions(+), 34 deletions(-)
> 
> ---------------------------------------------------------------- 
> ----------------------------------------------------------------
> 
> The following changes since commit 1f3b2d9cb040c0a694a2aaab2f291e750364d19a:
> 
>    UBUNTU: Ubuntu-aws-5.13.0-1007.8 (2021-11-15 12:37:18 -0600)
> 
> are available in the Git repository at:
> 
>    git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/impish
> 
> for you to fetch changes up to de09ef8982b9984666ace6b9056dc839018fd546:
> 
>    nitro_enclaves: Add fixes for checkpatch blank line reports (2021-11-22 
> 12:57:18 -0700)
> 
> ----------------------------------------------------------------
> Andra Paraschiv (7):
>        nitro_enclaves: Enable Arm64 support
>        nitro_enclaves: Update documentation for Arm64 support
>        nitro_enclaves: Add fix for the kernel-doc report
>        nitro_enclaves: Update copyright statement to include 2021
>        nitro_enclaves: Add fixes for checkpatch match open parenthesis reports
>        nitro_enclaves: Add fixes for checkpatch spell check reports
>        nitro_enclaves: Add fixes for checkpatch blank line reports
> 
> Longpeng(Mike) (1):
>        nitro_enclaves: Set Bus Master for the NE PCI device
> 
> Tim Gardner (1):
>        UBUNTU: [Config] aws: Update annotations for CONFIG_NITRO_ENCLAVES
> 
>   Documentation/virt/ne_overview.rst        | 21 +++++++++++++--------
>   debian.aws/config/annotations             |  1 +
>   drivers/virt/nitro_enclaves/Kconfig       |  8 ++------
>   drivers/virt/nitro_enclaves/ne_misc_dev.c | 17 +++++++++--------
>   drivers/virt/nitro_enclaves/ne_pci_dev.c  |  4 +++-
>   drivers/virt/nitro_enclaves/ne_pci_dev.h  |  8 ++++++--
>   include/uapi/linux/nitro_enclaves.h       | 10 +++++-----
>   samples/nitro_enclaves/ne_ioctl_sample.c  |  7 +++----
>   8 files changed, 42 insertions(+), 34 deletions(-)
> 
This seems to be done now as seperate submissions. So NACKing the all-in-one.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20211203/6c545021/attachment.sig>