ACK/Cmnt: [SRU][OEM-5.10][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 650 G8 Notebook PC

Jeremy Szu jeremy.szu at canonical.com
Tue Aug 31 13:16:11 UTC 2021


Hi Stefan and Tim.

Thanks for the comments.
When I drop this patch, it's because the schedule of the OEM project
is quite tight.
I don't want to use "UBUNTU: SAUCE:" for other series since the patch
was only in the maintainer's tree.
Thus, I submitted the "UBUNTU: SAUCE:" to OEM-5.10 for meeting the
project schedule and plan to work on other series after the patch is
landed in the mainline tree.
That's why I used [U/I/H/OEM-5.13/OEM-5.10] in the cover letter and
submitted the OEM-5.10 with "UBUNTU: SAUCE:" first.
In this case, how do you suggest dealing with this?

On Tue, Aug 31, 2021 at 9:02 PM Stefan Bader <stefan.bader於canonical.com> wrote:
>
> On 11.08.21 05:23, Jeremy Szu wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1939473
> >
> > The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is
> > using 0x02 to control mute LED and 0x01 to control micmute LED.
> > Therefore, add a quirk to make it works.
> >
> Signed-off-by: Jeremy Szu <jeremy.szu於canonical.com>
> Cc: <stable於vger.kernel.org>
> Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com
> Signed-off-by: Takashi Iwai <tiwai於suse.de>
> (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51 linux-next)
> > Signed-off-by: Jeremy Szu <jeremy.szu於canonical.com>
> Acked-by: Stefan Bader <stefan.bader於canonical.com>
> > ---
>
> As Tim mentioned the patch does not ask for this for Hirsute, also the bug
> report had no nomination for it (added) and neither does for oem-5.13.
>
> This is in linux-next now, so UBUNTU: SAUCE: should be dropped when applying
> with the extended sob area.
>
> -Stefan
> >   sound/pci/hda/patch_realtek.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 70da7e3716b4..22c2f323fbf8 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -8333,6 +8333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> >       SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
> > +     SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> >
>
>


-- 
Sincerely,
Jeremy Su



More information about the kernel-team mailing list