ACK/cmnt: [SRU][OEM-5.10][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 650 G8 Notebook PC

Kleber Souza kleber.souza at canonical.com
Tue Aug 31 13:06:22 UTC 2021


Jeremy,

This patch has only "[OEM-5.10]" on the subject line but on the cover
letter there's also "H/I/U/OEM-5.13". Could you please clarify if the
same patche should also be applied to these other kernels?

On 11.08.21 05:23, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939473
> 
> The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is
> using 0x02 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
> 
> Link: https://lore.kernel.org/lkml/20210810100846.65844-1-jeremy.szu@canonical.com/
> Signed-off-by: Jeremy Szu <jeremy.szu at canonical.com>

This patch has already been applied to Linus' tree, so the whole provenance
block should be:

Signed-off-by: Jeremy Szu <jeremy.szu at canonical.com>
Cc: <stable at vger.kernel.org>
Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com
Signed-off-by: Takashi Iwai <tiwai at suse.de>
(cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51)
Signed-off-by: Jeremy Szu <jeremy.szu at canonical.com>

And the "UBUNTU: SAUCE:" prefix on the subject line removed.


Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

Thanks


---
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 70da7e3716b4..22c2f323fbf8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -8333,6 +8333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
> +	SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> 




More information about the kernel-team mailing list