ACK/Cmnt: [SRU focal:linux-oem-5.6 focal:linux-oem-5.10] LP#1905013 -- express oem flavour explicitly V2

Stefan Bader stefan.bader at canonical.com
Mon Nov 23 07:48:55 UTC 2020


On 20.11.20 14:39, Andy Whitcroft wrote:
> All kernels have an intrisic flavour (generic, lowlatency, aws, oem etc).
> These are normally expressed in the binary package names from the
> primary package, and reflected into the meta packages names produced by
> linux-meta and linux-restricted-modules.  The flavours are further
> qualified via the variants system.
> 
> For the linux-oem-{5.6,5.10} packages the intrisic flavour is missing
> and is supplied via the variant.  This is wrong as we could never have
> a second flavour in this package.  This is incompatible with generating
> the package from the flavour names, as it does not have an intrinsic
> flavour.  Express the oem flavour explcitly for these packages.
> 
> There are three sets of patches.  The first patch is for
> kernel-series.yaml and corrects the variants there.  The next two
> patches are for linux-meta-oem-5.6 and linux-restricted-modules-5.10,
> and the final two are for linux-meta-oem-5.10 and linux-meta-oem-5.10.
> 
> I have compared the debian/control files before and after these updates
> and they are identicle.
> 
> It should be safe to apply the variants update to kteam-tools as soon as
> the remainder of the patches have been applied to the various branches,
> they do not need to be uploaded.
> 
> -apw
> 
Effectively this does not change anything (right now) aside from being brought
in line with the other derivatives. Still this should be ACKed by someone from
HWE (or having questions asked if things are unclear).

When applying, I would proposed to add the BugLink also to the
kernel-series.yaml commit to allow putting the pieces together more easily.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20201123/56488bf5/attachment.sig>


More information about the kernel-team mailing list