ACK/Cmnt: [G][F][B][X][PATCH 1/1] efivarfs: Replace invalid slashes with exclamation marks in dentries.

[Stefan Bader]

On 04.11.20 16:02, dann frazier wrote:
> From: Michael Schaller <misch at google.com>
> 
> BugLink: https:/bugs.launchpad.net/bugs/1899993
> 
> Without this patch efivarfs_alloc_dentry creates dentries with slashes in
> their name if the respective EFI variable has slashes in its name. This in
> turn causes EIO on getdents64, which prevents a complete directory listing
> of /sys/firmware/efi/efivars/.
> 
> This patch replaces the invalid shlashes with exclamation marks like
> kobject_set_name_vargs does for /sys/firmware/efi/vars/ to have consistently
> named dentries under /sys/firmware/efi/vars/ and /sys/firmware/efi/efivars/.
> 
> Signed-off-by: Michael Schaller <misch at google.com>
> Link: https://lore.kernel.org/r/20200925074502.150448-1-misch@google.com
> Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
> (cherry picked from commit 336af6a4686d885a067ecea8c3c3dd129ba4fc75)
> Signed-off-by: dann frazier <dann.frazier at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

Could you please add the reasoning in standard SRU template form to the bug
report. Otherwise appears ok.

-Stefan
>  fs/efivarfs/super.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c
> index 28bb5689333a..15880a68faad 100644
> --- a/fs/efivarfs/super.c
> +++ b/fs/efivarfs/super.c
> @@ -141,6 +141,9 @@ static int efivarfs_callback(efi_char16_t *name16, efi_guid_t vendor,
>  
>  	name[len + EFI_VARIABLE_GUID_LEN+1] = '\0';
>  
> +	/* replace invalid slashes like kobject_set_name_vargs does for /sys/firmware/efi/vars. */
> +	strreplace(name, '/', '!');
> +
>  	inode = efivarfs_get_inode(sb, d_inode(root), S_IFREG | 0644, 0,
>  				   is_removable);
>  	if (!inode)
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20201106/ff94b47f/attachment.sig>