ACK/Cmnt: [G][F][B][X][PATCH 1/1] efivarfs: Replace invalid slashes with exclamation marks in dentries.

[dann frazier]

On Fri, Nov 6, 2020 at 3:30 AM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 04.11.20 16:02, dann frazier wrote:
> > From: Michael Schaller <misch at google.com>
> >
> > BugLink: https:/bugs.launchpad.net/bugs/1899993
> >
> > Without this patch efivarfs_alloc_dentry creates dentries with slashes in
> > their name if the respective EFI variable has slashes in its name. This in
> > turn causes EIO on getdents64, which prevents a complete directory listing
> > of /sys/firmware/efi/efivars/.
> >
> > This patch replaces the invalid shlashes with exclamation marks like
> > kobject_set_name_vargs does for /sys/firmware/efi/vars/ to have consistently
> > named dentries under /sys/firmware/efi/vars/ and /sys/firmware/efi/efivars/.
> >
> > Signed-off-by: Michael Schaller <misch at google.com>
> > Link: https://lore.kernel.org/r/20200925074502.150448-1-misch@google.com
> > Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
> > (cherry picked from commit 336af6a4686d885a067ecea8c3c3dd129ba4fc75)
> > Signed-off-by: dann frazier <dann.frazier at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
> > ---
>
> Could you please add the reasoning in standard SRU template form to the bug
> report. Otherwise appears ok.

Now done, Cheers!

  -dann